Skip to content

refactor(sdk-logs)!: change SimpleLogRecordProcessor constructor signature#6836

Merged
trentm merged 3 commits into
open-telemetry:mainfrom
trentm:trentm-refactor-SimpleLogRecordProcessor
Jun 19, 2026
Merged

refactor(sdk-logs)!: change SimpleLogRecordProcessor constructor signature#6836
trentm merged 3 commits into
open-telemetry:mainfrom
trentm:trentm-refactor-SimpleLogRecordProcessor

Conversation

@trentm

@trentm trentm commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This changes SimpleLogRecordProcessor to taking an options object.
From this:

    new SimpleLogRecordProcessor(exporter)

to this:

    new SimpleLogRecordProcessor({ exporter })

This change is being made because:

…ature

This changes SimpleLogRecordProcessor to taking an options *object*.
From this:
    new SimpleLogRecordProcessor(exporter)
to this:
    new SimpleLogRecordProcessor({ exporter })

This change is being made because:
- the coming work for log record processor self-observability SDK
  metrics (open-telemetry#6554)
  needs to add options to the SimpleLogRecordProcessor constructor, and
- taking an options object will match the recent changes for
  BatchLogRecordProcessor and BatchSpanProcessor in
  open-telemetry#6817,
  and to SimpleSpanProcessor in open-telemetry#6504
@trentm trentm self-assigned this Jun 19, 2026
@trentm
trentm requested review from a team as code owners June 19, 2026 20:43
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.52%. Comparing base (9d7628f) to head (28ecfec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6836   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         384      384           
  Lines       12974    12974           
  Branches     2976     2976           
=======================================
  Hits        12394    12394           
  Misses        580      580           
Files with missing lines Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 96.93% <100.00%> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 96.41% <100.00%> (ø)
...es/sdk-logs/src/export/SimpleLogRecordProcessor.ts 93.54% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag maryliag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, otherwise lgtm

Comment thread experimental/CHANGELOG.md Outdated
@trentm
trentm added this pull request to the merge queue Jun 19, 2026
Merged via the queue into open-telemetry:main with commit c3bb4a3 Jun 19, 2026
29 checks passed
@trentm
trentm deleted the trentm-refactor-SimpleLogRecordProcessor branch June 19, 2026 22:56
@otelbot-js otelbot-js Bot mentioned this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants