refactor(sdk-logs)!: change SimpleLogRecordProcessor constructor signature#6836
Merged
trentm merged 3 commits intoJun 19, 2026
Merged
Conversation
…ature
This changes SimpleLogRecordProcessor to taking an options *object*.
From this:
new SimpleLogRecordProcessor(exporter)
to this:
new SimpleLogRecordProcessor({ exporter })
This change is being made because:
- the coming work for log record processor self-observability SDK
metrics (open-telemetry#6554)
needs to add options to the SimpleLogRecordProcessor constructor, and
- taking an options object will match the recent changes for
BatchLogRecordProcessor and BatchSpanProcessor in
open-telemetry#6817,
and to SimpleSpanProcessor in open-telemetry#6504
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6836 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 384 384
Lines 12974 12974
Branches 2976 2976
=======================================
Hits 12394 12394
Misses 580 580
🚀 New features to boost your workflow:
|
maryliag
approved these changes
Jun 19, 2026
maryliag
left a comment
Member
There was a problem hiding this comment.
just one nit, otherwise lgtm
david-luna
approved these changes
Jun 19, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes SimpleLogRecordProcessor to taking an options object.
From this:
to this:
This change is being made because:
metrics (feat(sdk-logs): implement log processor metrics #6554)
needs to add options to the SimpleLogRecordProcessor constructor, and
BatchLogRecordProcessor and BatchSpanProcessor in
refactor(sdk-logs, sdk-trace)!: refactor BatchSpanProcessor and BatchLogRecordProcessor constructor signature #6817,
and to SimpleSpanProcessor in feat(sdk-trace)!: implement span processor metrics; change SimpleSpanProcessor constructor call signature #6504