fix(sdk-node)!: remove buildSamplerFromConfig export#6784
Merged
trentm merged 2 commits intoJun 4, 2026
Conversation
This export was added in open-telemetry#6536 In early commits on that PR the functionality was added to the sdk-trace-base package, where an export would be necessary for sdk-node to use it for declarative config "create()". However, buildSamplerFromConfig was ultimately placed in sdk-node, which is the only expected place it will be used, at least currently. I don't think we need to export "build an SDK element from declarative Configuration properties" utilities *yet*. Not until there is an expectation of their being used outside of sdk-node, and us wanting to accept the extra maintenance surface area.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6784 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 377 377
Lines 12818 12818
Branches 2924 2924
=======================================
Hits 12168 12168
Misses 650 650 🚀 New features to boost your workflow:
|
maryliag
approved these changes
Jun 4, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in Declarative Configuration: JavaScript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This export was added in #6536
In early commits on that PR the functionality was added to the
sdk-trace-base package, where an export would be necessary for sdk-node
to use it for declarative config "create()".
However, buildSamplerFromConfig was ultimately placed in sdk-node,
which is the only expected place it will be used, at least currently.
I don't think we need to export "build an SDK element from declarative
Configuration properties" utilities yet. Not until there is an
expectation of their being used outside of sdk-node, and us wanting
to accept the extra maintenance surface area.