-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(configuration): bump config schema to v1.1.0, apply Prometheus property rename #6781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
c1d3a92
e92d368
ccf2f19
97d7b50
aea359d
78a7195
bcaf763
da1c470
32f5499
b92a6df
938c1b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,8 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2 | |
|
|
||
| ### :boom: Breaking Changes | ||
|
|
||
| * chore(configuration)!: bump config schema to v1.1.0; rename `without_scope_info` → `scope_info_enabled` and `without_target_info/development` → `target_info_enabled/development` on the Prometheus pull exporter (semantics inverted), rename `with_resource_constant_labels` → `resource_constant_labels`. Validate `file_format` per the configuration versioning spec: accept any minor version of major `1` (e.g. `1.0`, `1.1`), warn when the minor version is newer than supported, and reject other major versions. [#6781](https://github.com/open-telemetry/opentelemetry-js/pull/6781) @MikeGoldsmith | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Q: is this breaking now? It might not be.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically it is a breaking change for anyone who was using
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. Per the configuration repo's versioning doc, anything |
||
|
|
||
| ### :rocket: Features | ||
|
|
||
| ### :bug: Bug Fixes | ||
|
|
||
|
MikeGoldsmith marked this conversation as resolved.
|
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.