fix(browser-detector): fix name for user agent resource attribute#6729
Merged
pichlermarc merged 5 commits intoMay 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6729 +/- ##
=======================================
Coverage 94.94% 94.95%
=======================================
Files 377 377
Lines 12730 12734 +4
Branches 2893 2893
=======================================
+ Hits 12087 12091 +4
Misses 643 643
🚀 New features to boost your workflow:
|
pichlermarc
approved these changes
May 21, 2026
joaquin-diaz
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Browser detector is sending the wrong semantic convetion for user agent. This PR adds
@opentelemetry/semantic-conventionsdependency into browser detector package and also aligns with other packages in the way incubating semconv are implemented.Short description of the changes
ATTR_USER_AGENT_ORIGINALattribute in resource detectionsemconv.tsfile with the incubating attributes and remove the current enumType of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: