fix(api-logs)!: minimize noop logger exports#6713
Merged
trentm merged 2 commits intoMay 15, 2026
Merged
Conversation
|
|
Replace the exported `NOOP_LOGGER` constant and `NoopLogger` class with a single `createNoopLogger(): Logger` function, following the same pattern as the metrics API's `createNoopMeter()`. The return type is narrowed to `Logger` to guarantee only the minimum required interface. Fixes open-telemetry#6681
dyladan
force-pushed
the
fix/api-logs-minimize-noop-exports
branch
from
May 13, 2026 19:17
81f37cb to
6f3733b
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6713 +/- ##
==========================================
- Coverage 94.84% 94.83% -0.01%
==========================================
Files 376 376
Lines 12702 12704 +2
Branches 2885 2885
==========================================
+ Hits 12047 12048 +1
- Misses 655 656 +1
🚀 New features to boost your workflow:
|
trentm
approved these changes
May 14, 2026
trentm
left a comment
Contributor
There was a problem hiding this comment.
nit: Put ! for breaking in the PR title?
Member
Author
done |
david-luna
approved these changes
May 15, 2026
Merged
via the queue into
open-telemetry:main
with commit May 15, 2026
6d5f93e
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOOP_LOGGERconstant andNoopLoggerclass with a singlecreateNoopLogger(): Loggerfunction, following the same pattern as the metrics API'screateNoopMeter()Loggerto guarantee only the minimum required interfacesdk-logsLoggerProviderto usecreateNoopLogger()instead ofNOOP_LOGGERinstanceof NoopLoggerto use behavioral checks insteadTest plan
api-logstests passsdk-logstests passFixes #6681
🤖 Generated with Claude Code