Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioredis plugin] fix: change supportedVersions to >1 <5 #671

Merged
merged 8 commits into from
Jan 28, 2020
Merged

[ioredis plugin] fix: change supportedVersions to >1 <5 #671

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
572b7d7
fix: change supportedVersions to 4.x.x
naseemkullah Jan 7, 2020
e6f444a
Merge remote-tracking branch 'upstream/master' into ioredis-supported…
Jan 21, 2020
0be0c5a
fix: supported versions
Jan 21, 2020
c159f4d
Merge branch 'master' into ioredis-supported-versions
Jan 23, 2020
d451356
Merge branch 'master' into ioredis-supported-versions
dyladan Jan 24, 2020
17f1fe6
Merge branch 'master' into ioredis-supported-versions
dyladan Jan 24, 2020
c9a640f
Merge branch 'master' into ioredis-supported-versions
dyladan Jan 28, 2020
d2f3a89
Merge branch 'master' into ioredis-supported-versions
dyladan Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/opentelemetry-plugin-ioredis/src/ioredis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { VERSION } from './version';
export class IORedisPlugin extends BasePlugin<typeof ioredisTypes> {
static readonly COMPONENT = 'ioredis';
static readonly DB_TYPE = 'redis';
readonly supportedVersions = ['^2.0.0'];
readonly supportedVersions = ['>1 <5'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support version 1.x.x? This version string will match that I believe? I think you're looking for '>=2 <5'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://semver.npmjs.com/ it's fine 🤷‍♂


constructor(readonly moduleName: string) {
super('@opentelemetry/plugin-ioredis', VERSION);
Expand Down