Skip to content

feat(otlp-transformer): add custom logs response deserializer#6530

Merged
pichlermarc merged 4 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:feat/custom-proto-logs-response-deserializer
Apr 7, 2026
Merged

feat(otlp-transformer): add custom logs response deserializer#6530
pichlermarc merged 4 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:feat/custom-proto-logs-response-deserializer

Conversation

@pichlermarc
Copy link
Copy Markdown
Member

@pichlermarc pichlermarc commented Mar 27, 2026

Which problem is this PR solving?

Follow-up to #6390; replaces protobuf.js in logs response deserialization with a custom implementation.
Also removes generated code for OTLP logs from the published package, since we don't need it anymore.

The goal of this PR is not to improve performance but to fix:

Once this is merged, we can also go ahead an migrate the other signals away from protobuf.js, following the patterns from this PR and #6390; in the last PR, we should remove protobuf.js as a production dependency and move it to devDependencies instead. Once this is done #4987 should be fixed.

Disclosure of AI use: I used GitHub copilot with Claude Sonnet 4.6 to help with implementation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Existing unit tests
  • Added unit tests

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 97.84946% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.75%. Comparing base (1cf5ef3) to head (b80fc89).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...transformer/src/common/protobuf/protobuf-reader.ts 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6530      +/-   ##
==========================================
+ Coverage   95.74%   95.75%   +0.01%     
==========================================
  Files         371      373       +2     
  Lines       12514    12604      +90     
  Branches     2962     2982      +20     
==========================================
+ Hits        11981    12069      +88     
- Misses        533      535       +2     
Files with missing lines Coverage Δ
...ackages/otlp-transformer/src/logs/protobuf/logs.ts 100.00% <100.00%> (ø)
...sformer/src/logs/protobuf/response-deserializer.ts 100.00% <100.00%> (ø)
...transformer/src/common/protobuf/protobuf-reader.ts 96.07% <96.07%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc force-pushed the feat/custom-proto-logs-response-deserializer branch from 75117f1 to ac289c4 Compare March 27, 2026 15:51
@pichlermarc pichlermarc force-pushed the feat/custom-proto-logs-response-deserializer branch from ac289c4 to ebce3d7 Compare March 27, 2026 16:38
@pichlermarc pichlermarc marked this pull request as ready for review March 27, 2026 17:45
@pichlermarc pichlermarc requested a review from a team as a code owner March 27, 2026 17:45
Copy link
Copy Markdown
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I haven't hammered it with testing.

* Copyright The OpenTelemetry Authors
* SPDX-License-Identifier: Apache-2.0
*/
import * as root from '../../generated/root';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And almost 1MiB of JS just left the process.
... or almost (need trace and metrics as well).

@trentm
Copy link
Copy Markdown
Contributor

trentm commented Apr 2, 2026

Guessing the merge conflict is because I separately moved the changelog entry for the earlier change up to the top, not noticing that you were doing so here.

@pichlermarc pichlermarc added this pull request to the merge queue Apr 7, 2026
Merged via the queue into open-telemetry:main with commit cc59bdc Apr 7, 2026
27 checks passed
@pichlermarc pichlermarc deleted the feat/custom-proto-logs-response-deserializer branch April 7, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants