feat(otlp-transformer): add custom logs response deserializer#6530
Merged
pichlermarc merged 4 commits intoopen-telemetry:mainfrom Apr 7, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6530 +/- ##
==========================================
+ Coverage 95.74% 95.75% +0.01%
==========================================
Files 371 373 +2
Lines 12514 12604 +90
Branches 2962 2982 +20
==========================================
+ Hits 11981 12069 +88
- Misses 533 535 +2
🚀 New features to boost your workflow:
|
75117f1 to
ac289c4
Compare
4 tasks
ac289c4 to
ebce3d7
Compare
trentm
approved these changes
Apr 2, 2026
Contributor
trentm
left a comment
There was a problem hiding this comment.
I think this looks good. I haven't hammered it with testing.
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| import * as root from '../../generated/root'; |
Contributor
There was a problem hiding this comment.
And almost 1MiB of JS just left the process.
... or almost (need trace and metrics as well).
Contributor
|
Guessing the merge conflict is because I separately moved the changelog entry for the earlier change up to the top, not noticing that you were doing so here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Follow-up to #6390; replaces protobuf.js in logs response deserialization with a custom implementation.
Also removes generated code for OTLP logs from the published package, since we don't need it anymore.
The goal of this PR is not to improve performance but to fix:
Once this is merged, we can also go ahead an migrate the other signals away from protobuf.js, following the patterns from this PR and #6390; in the last PR, we should remove
protobuf.jsas a production dependency and move it todevDependenciesinstead. Once this is done #4987 should be fixed.Disclosure of AI use: I used GitHub copilot with Claude Sonnet 4.6 to help with implementation.
Type of change
How Has This Been Tested?