perf(sdk-trace-base): optimize Span.{addEvent,addLink} performance#6516
Merged
dyladan merged 2 commits intoopen-telemetry:mainfrom Mar 23, 2026
Merged
Conversation
6a36026 to
d9cb962
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
==========================================
- Coverage 95.75% 95.73% -0.02%
==========================================
Files 364 364
Lines 12096 12104 +8
Branches 2885 2887 +2
==========================================
+ Hits 11582 11588 +6
- Misses 514 516 +2
🚀 New features to boost your workflow:
|
dyladan
approved these changes
Mar 21, 2026
Contributor
Author
|
Fixed my conflicts from |
Contributor
|
Thank you for your contribution @daniellockyer! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Improves the performance of
Span.{addEvent,addLink}by applying the same changes as b97b488 (by @AbhiPrasad) and #6514 (by me)Before:
After:
refs #6100
Short description of the changes
Object.entries, as this is not performant as a for-in loopObject.keys(..).lengthin a loop and use a variable to track countType of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as expected)This change requires a documentation updateHow Has This Been Tested?
Tests still pass, and you can see benchmarks above
Checklist:
Unit tests have been addedDocumentation has been updated