fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6430
Closed
slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6430slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…tXPath The optimised parameter was hardcoded to false in the recursive call, preventing ancestor nodes from using ID-based shortcuts when optimised mode was enabled. Fixes open-telemetry#6323
|
Member
|
closing as duplicate of #6335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6323
Problem
getElementXPathhardcodesfalsefor theoptimisedparameter in the recursive call to traverse parent nodes:This means when
optimised=true, ancestor nodes with IDs are not used as shortcuts, producing incorrect/longer XPaths.Fix
Pass the
optimisedparameter through the recursive call:Example
Given
<body id="body-id"><div></div></body>:getElementXPath(div, true)→/html/body/div(ignores body's id)getElementXPath(div, true)→//*[@id="body-id"]/div(uses id shortcut)