fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6429
Closed
slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
fix(sdk-trace-web): pass optimised parameter recursively in getElementXPath#6429slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
slegarraga wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…tXPath The getElementXPath function was hardcoding false for the optimised parameter when recursing to parent nodes. This caused child elements of nodes with IDs to produce non-optimised XPaths (e.g. //html/body/div instead of //*[@id="parent-id"]/div) even when optimised=true was requested. Fixes open-telemetry#6323
|
Member
|
closing as duplicate of #6335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6323
Problem
getElementXPathhardcodesfalsefor theoptimisedparameter when recursing to parent nodes:This means child elements of nodes with IDs produce non-optimised XPaths even when
optimised=trueis requested://*[@id="body-id"]/div//html/body/divFix
Changed
falsetooptimisedso the parameter is correctly passed through recursive calls:Also added a test case verifying that child elements of id-bearing ancestors use the optimised
@idshortcut.