Skip to content

chore(deps): update dependency eslint to v10 - manually fixed#6382

Merged
overbalance merged 13 commits into
mainfrom
renovate/major-eslint-monorepo
May 27, 2026
Merged

chore(deps): update dependency eslint to v10 - manually fixed#6382
overbalance merged 13 commits into
mainfrom
renovate/major-eslint-monorepo

Conversation

@renovate

@renovate renovate Bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Migration notes

ESLint 10 mandates flat config, removes --ext, drops .eslintignore, and turns on reportUnusedDisableDirectives by default. This PR carries the renovate dependency bump plus four follow-up commits to make the migration land.

Config

  • New root eslint.config.mjs (flat config); deleted 45 .eslintrc.js, 43 .eslintignore, and eslint.base.js.
  • Dependency swaps:
    • @typescript-eslint/eslint-plugin + @typescript-eslint/parsertypescript-eslint (single meta-package).
    • eslint-plugin-header (unmaintained, incompatible with flat config) → eslint-plugin-yet-another-license-header (matches opentelemetry-js-contrib).
    • Added @eslint/js, globals.
  • Per-package lint / lint:fix scripts: dropped --ext .ts|.js|.mjs. Flat config selects files via files: patterns instead.
  • Patched eslint-plugin-yet-another-license-header@0.2.0 inline: under ESLint 10, getCommentsBefore(programNode) returns 0 comments where ESLint 9 returned the leading file comment, which made the plugin treat already-headered files as missing the header and append a duplicate on every --fix. The patch redirects the lookup to getCommentsBefore(programNode.body[0]). Drop the wrapper once upstream supports ESLint 10.
  • Ignored experimental/packages/configuration/test/fixtures/types/** (tsd-style fixtures intentionally outside tsconfig, otherwise the typed parser fails to load them).

lint:examples parity

The legacy examples/.eslintrc.js was a standalone config that did not extend the base, so eslint:recommended and prettier rules were never enforced on example code. The new flat config inherits from a shared base block, which is correct in principle but would surface ~400 pre-existing prettier issues in examples/ and fail the CI Lint job. To keep the PR scoped to the ESLint 10 migration, the examples block disables prettier/prettier, quotes, no-console, and no-unused-vars, matching the legacy effective ruleset. Tightening up examples is out of scope; that's its own change. The two protobuf-generated files in examples/grpc-js/ (helloworld_pb.js, helloworld_grpc_pb.js) are also globally ignored.

Source fixes

ESLint 10's recommended set adds rules that surfaced real issues in the tree. Fixed rather than suppressed:

  • preserve-caught-error (new in ESLint 10): EnvDetector.ts now attaches cause: e when wrapping a URIError. This is a small behavior change; error.cause will now expose the original error to anything that walks it.
  • no-useless-assignment (new in ESLint 9): three places where an assigned value was never observed before being overwritten or dropped (utils.ts, ExponentialHistogram.test.ts, sampler-composite/test/util.ts).
  • no-sparse-arrays: one test deliberately constructs a sparse array; switched to a single-line eslint-disable-next-line so prettier and the rule both stay happy.

Cleanup

reportUnusedDisableDirectives flagged a number of // eslint-disable-next-line comments for rules that were never actually enabled (for example n/no-unsupported-features/node-builtins, @typescript-eslint/no-non-null-assertion). ESLint 8 silently allowed unused directives; ESLint 9+ warns by default. --fix removed them.

Verified

  • npm run lint (44 nx projects + markdown + semconv-deps): clean.
  • npm run lint:examples: clean.

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Confidence
eslint (source) 8.57.110.3.0 age confidence

Release Notes

eslint/eslint (eslint)

v10.3.0

Compare Source

v10.2.1

Compare Source

v10.2.0

Compare Source

Features

Bug Fixes

Documentation

  • a2af743 docs: add language to configuration objects (#​20712) (Francesco Trotta)
  • 845f23f docs: Update README (GitHub Actions Bot)
  • 5fbcf59 docs: remove sourceType from ts playground link (#​20477) (Tanuj Kanti)
  • 8702a47 docs: Update README (GitHub Actions Bot)
  • ddeaded docs: Update README (GitHub Actions Bot)
  • 2b44966 docs: add Major Releases section to Manage Releases (#​20269) (Milos Djermanovic)
  • eab65c7 docs: update eslint versions in examples (#​20664) (루밀LuMir)
  • 3e4a299 docs: update ESM Dependencies policies with note for own-usage packages (#​20660) (Milos Djermanovic)

Chores

  • 8120e30 refactor: extract no unmodified loop condition (#​20679) (kuldeep kumar)
  • 46e8469 chore: update dependency markdownlint-cli2 to ^0.22.0 (#​20697) (renovate[bot])
  • 01ed3aa test: add unit tests for unicode utilities (#​20622) (Manish chaudhary)
  • 811f493 ci: remove --legacy-peer-deps from types integration tests (#​20667) (Milos Djermanovic)
  • 6b86fcf chore: update dependency npm-run-all2 to v8 (#​20663) (renovate[bot])
  • 632c4f8 chore: add prettier update commit to .git-blame-ignore-revs (#​20662) (루밀LuMir)
  • b0b0f21 chore: update dependency eslint-plugin-regexp to ^3.1.0 (#​20659) (Milos Djermanovic)
  • 228a2dd chore: update dependency eslint-plugin-eslint-plugin to ^7.3.2 (#​20661) (Milos Djermanovic)
  • 3ab4d7e test: Add tests for eslintrc-style keys (#​20645) (kuldeep kumar)

v10.1.0

Compare Source

Features

  • ff4382b feat: apply fix for no-var in TSModuleBlock (#​20638) (Tanuj Kanti)
  • 0916995 feat: Implement api support for bulk-suppressions (#​20565) (Blake Sager)

Bug Fixes

  • 2b8824e fix: Prevent no-var autofix when a variable is used before declaration (#​20464) (Amaresh S M)
  • e58b4bf fix: update eslint (#​20597) (renovate[bot])

Documentation

  • b7b57fe docs: use correct JSDoc link in require-jsdoc.md (#​20641) (mkemna-clb)
  • 58e4cfc docs: add deprecation notice partial (#​20639) (Milos Djermanovic)
  • 7143dbf docs: update v9 migration guide for @eslint/js usage (#​20540) (fnx)
  • 035fc4f docs: note that globalReturn applies only with sourceType: "script" (#​20630) (Milos Djermanovic)
  • e972c88 docs: merge ESLint option descriptions into type definitions (#​20608) (Francesco Trotta)
  • 7f10d84 docs: Update README (GitHub Actions Bot)
  • aeed007 docs: open playground link in new tab (#​20602) (Tanuj Kanti)
  • a0d1a37 docs: Add AI Usage Policy (#​20510) (Nicholas C. Zakas)

Chores

v10.0.3

Compare Source

v10.0.2

Compare Source

v10.0.1

Compare Source

Bug Fixes

Documentation

  • 5b3dbce docs: add AI acknowledgement section to templates (#​20431) (루밀LuMir)
  • 6f23076 docs: toggle nav in no-JS mode (#​20476) (Tanuj Kanti)
  • b69cfb3 docs: Update README (GitHub Actions Bot)

Chores

v10.0.0

Compare Source

v9.39.4

Compare Source

Bug Fixes

Documentation

Chores

v9.39.3

Compare Source

Bug Fixes

  • 791bf8d fix: restore TypeScript 4.0 compatibility in types (#​20504) (sethamus)

Chores

v9.39.2

Compare Source

v9.39.1

Compare Source

v9.39.0

Compare Source

v9.38.0

Compare Source

Features

  • ce40f74 feat: update complexity rule to only highlight function header (#​20048) (Atul Nair)
  • e37e590 feat: correct no-loss-of-precision false positives with e notation (#​20187) (Francesco Trotta)

Bug Fixes

  • 50c3dfd fix: improve type support for isolated dependencies in pnpm (#​20201) (Francesco Trotta)
  • a1f06a3 fix: correct SourceCode typings (#​20114) (Pixel998)

Documentation

  • 462675a docs: improve web accessibility by hiding non-semantic character (#​20205) (루밀LuMir)
  • c070e65 docs: correct formatting in no-irregular-whitespace rule documentation (#​20203) (루밀LuMir)
  • b39e71a docs: Update README (GitHub Actions Bot)
  • cd39983 docs: move custom-formatters type descriptions to nodejs-api (#​20190) (Percy Ma)

Chores

v9.37.0

Compare Source

Features

  • 39f7fb4 feat: preserve-caught-error should recognize all static "cause" keys (#​20163) (Pixel998)
  • f81eabc feat: support TS syntax in no-restricted-imports (#​19562) (Nitin Kumar)

Bug Fixes

Documentation

  • b950359 docs: fix typos across the docs (#​20182) (루밀LuMir)
  • 42498a2 docs: improve ToC accessibility by hiding non-semantic character (#​20181) (Percy Ma)
  • 29ea092 docs: Update README (GitHub Actions Bot)
  • 5c97a04 docs: show availableUntil in deprecated rule banner (#​20170) (Pixel998)
  • 90a71bf docs: update README files to add badge and instructions (#​20115) (루밀LuMir)
  • 1603ae1 docs: update references from master to main (#​20153) (루밀LuMir)

Chores

  • afe8a13 chore: update @eslint/js dependency to version 9.37.0 (#​20183) (Francesco Trotta)
  • abee4ca chore: package.json update for @​eslint/js release (Jenkins)
  • fc9381f chore: fix typos in comments (#​20175) (overlookmotel)
  • e1574a2 chore: unpin jiti (#​20173) (renovate[bot])
  • e1ac05e refactor: mark ESLint.findConfigFile() as async, add missing docs (#​20157) (Pixel998)
  • 347906d chore: update eslint (#​20149) (renovate[bot])
  • 0cb5897 test: remove tmp dir created for circular fixes in multithread mode test (#​20146) (Milos Djermanovic)
  • bb99566 ci: pin jiti to version 2.5.1 (#​20151) (Pixel998)
  • 177f669 perf: improve worker count calculation for "auto" concurrency (#​20067) (Francesco Trotta)
  • 448b57b chore: Mark deprecated formatting rules as available until v11.0.0 (#​20144) (Milos Djermanovic)

v9.36.0

Compare Source

Features

  • 47afcf6 feat: correct preserve-caught-error edge cases (#​20109) (Francesco Trotta)

Bug Fixes

Documentation

  • b73ab12 docs: update examples to use defineConfig (#​20131) (sethamus)
  • 31d9392 docs: fix typos (#​20118) (Pixel998)
  • c7f861b docs: Update README (GitHub Actions Bot)
  • 6b0c08b docs: Update README (GitHub Actions Bot)
  • 91f97c5 docs: Update README (GitHub Actions Bot)

Chores

  • 12411e8 chore: upgrade @​eslint/js@​9.36.0 (#​20139) (Milos Djermanovic)
  • 488cba6 chore: package.json update for @​eslint/js release (Jenkins)
  • bac82a2 ci: simplify renovate configuration (#​19907) (唯然)
  • c00bb37 ci: bump actions/labeler from 5 to 6 (#​20090) (dependabot[bot])
  • fee751d refactor: use defaultOptions in rules (#​20121) (Pixel998)
  • 1ace67d chore: update example to use defineConfig (#​20111) (루밀LuMir)
  • 4821963 test: add missing loc information to error objects in rule tests (#​20112) (루밀LuMir)
  • b42c42e chore: disallow use of deprecated type property in core rule tests (#​20094) (Milos Djermanovic)
  • 7bb498d test: remove deprecated type property from core rule tests (#​20093) (Pixel998)
  • e10cf2a ci: bump actions/setup-node from 4 to 5 (#​20089) (dependabot[bot])
  • 5cb0ce4 refactor: use meta.defaultOptions in preserve-caught-error (#​20080) (Pixel998)
  • f9f7cb5 chore: package.json update for eslint-config-eslint release (Jenkins)
  • 81764b2 chore: update eslint peer dependency in eslint-config-eslint (#​20079) (Milos Djermanovic)

v9.35.0

Compare Source

Features

  • 42761fa feat: implement suggestions for no-empty-function (#​20057) (jaymarvelz)
  • 102f444 feat: implement suggestions for no-empty-static-block (#​20056) (jaymarvelz)
  • e51ffff feat: add preserve-caught-error rule (#​19913) (Amnish Singh Arora)

Bug Fixes

  • 10e7ae2 fix: update uncloneable options error message (#​20059) (soda-sorcery)
  • bfa4601 fix: ignore empty switch statements with comments in no-empty rule (#​20045) (jaymarvelz)
  • dfd11de fix: add before and after to test case types (#​20049) (Francesco Trotta)
  • dabbe95 fix: correct types for no-restricted-imports rule (#​20034) (Milos Djermanovic)
  • ea789c7 fix: no-loss-of-precision false positive with uppercase exponent (#​20032) (sethamus)

Documentation

  • d265515 docs: improve phrasing - "if" → "even if" from getting-started section (#​20074) (jjangga0214)
  • a355a0e docs: invert comparison logic for example in no-var doc page (#​20064) (OTonGitHub)
  • 5082fc2 docs: Update README (GitHub Actions Bot)
  • 99cfd7e docs: add missing "the" in rule deprecation docs (#​20050) (Josh Goldberg ✨)
  • 6ad8973 docs: update --no-ignore and --ignore-pattern documentation (#​20036) (Francesco Trotta)
  • 8033b19 docs: add documentation for --no-config-lookup (#​20033) (Francesco Trotta)

Chores

v9.34.0

Compare Source

Features

  • 0bb777a feat: multithread linting (#​19794) (Francesco Trotta)
  • 43a5f9e feat: add eslint-plugin-regexp to eslint-config-eslint base config (#​19951) (Pixel998)

Bug Fixes

  • 9b89903 fix: default value of accessor-pairs option in rule.d.ts file (#​20024) (Tanuj Kanti)
  • 6c07420 fix: fix spurious failure in neostandard integration test (#​20023) (Kirk Waiblinger)
  • 676f4ac fix: allow scientific notation with trailing zeros matching exponent (#​20002) (Sweta Tanwar)

Documentation

  • 0b4a590 docs: make rulesdir deprecation clearer (#​20018) (Domenico Gemoli)
  • 327c672 docs: Update README (GitHub Actions Bot)
  • bf26229 docs: Fix typo in core-concepts/index.md (#​20009) (Tobias Hernstig)
  • 2309327 docs: fix typo in the "Configuring Rules" section (#​20001) (ghazi-git)
  • 2b87e21 docs: [no-else-return] clarify sample code. (#​19991) (Yuki Takada (Yukinosuke Takada))
  • c36570c docs: Update README (GitHub Actions Bot)

Chores

v9.33.0

Compare Source

Features

  • e07820e feat: add global object access detection to no-restricted-globals (#​19939) (sethamus)
  • 90b050e feat: support explicit resource management in one-var (#​19941) (Sweta Tanwar)

Bug Fixes

  • 732433c fix: allow any type for meta.docs.recommended in custom rules (#​19995) (Francesco Trotta)
  • e8a6914 fix: Fixed potential bug in check-emfile-handling.js (#​19975) (諏訪原慶斗)

Documentation

  • 34f0723 docs: playground button for TypeScript code example (#​19671) (Tanuj Kanti)
  • dc942a4 docs: Update README (GitHub Actions Bot)
  • 5a4b6f7 docs: Update no-multi-assign.md (#​19979) (Yuki Takada (Yukinosuke Takada))
  • 247e156 docs: add missing let declarations in no-plusplus (#​19980) (Yuki Takada (Yukinosuke Takada))
  • 0d17242 docs: Update README (GitHub Actions Bot)
  • fa20b9d docs: Clarify when to open an issue for a PR (#​19974) (Nicholas C. Zakas)

Build Related

  • 27fa865 build: use ESLint class to generate formatter examples (#​19972) (Milos Djermanovic)

Chores

v9.32.0

Compare Source

Features

Bug Fixes

Documentation

  • 86e7426 docs: Update README (GitHub Actions Bot)

Chores

  • 50de1ce chore: package.json update for @​eslint/js release (Jenkins)
  • 74f01a3 ci: unpin jiti to version ^2.5.1 (#​19970) (루밀LuMir)
  • 2ab1381 ci: pin jiti to version 2.4.2 (#​19964) (Francesco Trotta)
  • b7f7545 test: switch to flat config mode in SourceCode tests (#​19953) (Milos Djermanovic)
  • f5a35e3 test: switch to flat config mode in eslint-fuzzer (#​19960) (Milos Djermanovic)
  • e22af8c refactor: use CustomRuleDefinitionType in JSRuleDefinition (#​19949) (Francesco Trotta)
  • e855717 chore: switch performance tests to hyperfine (#​19919) (Francesco Trotta)
  • 2f73a23 test: switch to flat config mode in ast-utils tests (#​19948) (Milos Djermanovic)
  • c565a53 chore: exclude further_reading_links.json from Prettier formatting (#​19943) (Milos Djermanovic)

v9.31.0

Compare Source

Features

  • 35cf44c feat: output full actual location in rule tester if different (#​19904) (ST-DDT)
  • a6a6325 feat: support explicit resource management in no-loop-func (#​19895) (Milos Djermanovic)
  • 4682cdc feat: support explicit resource management in no-undef-init (#​19894) (Milos Djermanovic)
  • 5848216 feat: support explicit resource management in init-declarations (#​19893) (Milos Djermanovic)
  • bb370b8 feat: support explicit resource management in no-const-assign (#​19892) (Milos Djermanovic)

Bug Fixes

  • 07fac6c fix: retry on EMFILE when writing autofix results (#​19926) (TKDev7)
  • 28cc7ab fix: Remove incorrect RuleContext types (#​19910) (Nicholas C. Zakas)

Documentation

  • 664cb44 docs: Update README (GitHub Actions Bot)
  • 40dbe2a docs: fix mismatch between globalIgnores() code and text (#​19914) (MaoShizhong)
  • 5a0069d docs: Update README (GitHub Actions Bot)
  • fef04b5 docs: Update working on issues info (#​19902) (Nicholas C. Zakas)

Chores

Note

PR body was truncated to here.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 3am on Monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner February 9, 2026 00:45
@renovate renovate Bot added the dependencies Pull requests that update a dependency file label Feb 9, 2026
@renovate

This comment was marked as outdated.

@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 4706ac8 to 950ebbc Compare February 17, 2026 18:30
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 950ebbc to fd7d2e0 Compare February 24, 2026 00:36
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 8829d8b to 3060522 Compare March 7, 2026 00:44
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from 3060522 to 40ec607 Compare March 13, 2026 13:34
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from ac0d888 to dc81fea Compare March 27, 2026 12:31
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 3 times, most recently from 23f24e7 to b5edcd5 Compare April 8, 2026 14:41
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch from b5edcd5 to 680adb7 Compare April 17, 2026 20:27
@renovate
renovate Bot force-pushed the renovate/major-eslint-monorepo branch 2 times, most recently from 8871ac5 to 3a5d8eb Compare May 1, 2026 16:33
@overbalance
overbalance requested review from a team as code owners May 5, 2026 02:08
@overbalance overbalance changed the title chore(deps): update dependency eslint to v10 chore(deps): update dependency eslint to v10 - manually fixed May 5, 2026
@renovate

renovate Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (8edcb66) to head (a2c3f18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6382      +/-   ##
==========================================
- Coverage   94.92%   94.92%   -0.01%     
==========================================
  Files         377      377              
  Lines       12818    12817       -1     
  Branches     2924     2924              
==========================================
- Hits        12168    12167       -1     
  Misses        650      650              
Files with missing lines Coverage Δ
.../packages/configuration/scripts/generate-config.js 0.00% <ø> (ø)
...ages/configuration/src/EnvironmentConfigFactory.ts 97.24% <ø> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 84.58% <ø> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 87.50% <ø> (ø)
...ckages/opentelemetry-instrumentation/src/semver.ts 95.30% <100.00%> (ø)
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 95.93% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 97.12% <100.00%> (ø)
...e/src/configuration/otlp-grpc-env-configuration.ts 100.00% <100.00%> (ø)
...perimental/packages/sdk-logs/src/LoggerProvider.ts 100.00% <ø> (ø)
...es/sdk-logs/src/export/SimpleLogRecordProcessor.ts 93.54% <ø> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance
overbalance force-pushed the renovate/major-eslint-monorepo branch from 85a18b9 to 6eca917 Compare May 18, 2026 22:13
Comment thread eslint.config.mjs Outdated
// ESLint 10. Wrap the rule so it inspects comments before the first
// statement instead, which is the correct location for a leading file
// header. Drop this once the upstream plugin supports ESLint 10.
const patchedHeaderRule = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overbalance Thanks for this! There is now a eslint-plugin-yet-another-license-header@1.0.0 with your fix. It tests against eslint@9 and eslint@10 now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from here, thanks!

@overbalance
overbalance requested a review from trentm May 26, 2026 20:48

@trentm trentm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heart.
LGTM.

Comment thread eslint.config.mjs
*/
`;

// Accept either the full Apache 2.0 header or the SPDX short form.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there still files in here using the long one? I haven't looked.
... ah, .js and .mjs files which (I'm guessing) are now being processed and weren't before.

Perhaps in a separate change we could move all those files to the shorter one.

Comment thread eslint.config.mjs
],
plugins: {
n: nodePlugin,
prettier: prettierPlugin,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, in opentelemetry-js-contrib we moved prettier outside of the eslint run. I don't have a strong pref. Eventually it would be nice to have similar tooling behaviour across the repos, but that can come later.

Comment thread eslint.config.mjs
rules: {
'@typescript-eslint/no-floating-promises': 'error',
'@typescript-eslint/no-this-alias': 'off',
'@typescript-eslint/naming-convention': [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't require a "plugins" entry something like this?

    plugins: {
      '@typescript-eslint': tseslint.plugin,
    },

I'm comparing to opentelemetry-js-contrib/eslint.config.mjs.

I guess the plugins entry isn't required. Not ever block in "opentelemetry-js-contrib/eslint.config.mjs" that uses @typescript-eslint/... rules has a "plugins" entry. /shrug

@overbalance
overbalance added this pull request to the merge queue May 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 27, 2026
@overbalance
overbalance added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit baef99b May 27, 2026
32 checks passed
@overbalance
overbalance deleted the renovate/major-eslint-monorepo branch May 27, 2026 01:52
MikeGoldsmith added a commit to honeycombio/opentelemetry-js that referenced this pull request Jun 8, 2026
…omments

Trent's review feedback on open-telemetry#6781: the eslint config v10 update
(open-telemetry#6382) accidentally added the generated config files to the ignore
list, so npm run lint:fix in the codegen no longer ran on them. This
produced formatting noise in generated types.ts.

- Remove the experimental/packages/configuration/src/generated/**
  ignore from eslint.config.mjs so lint:fix runs on these files
- Drop the now-redundant /* eslint-disable */ header in validator.js
  and validator.d.ts (lint:fix handles formatting; the AUTO-GENERATED
  comment signals intent)
- Regenerate types and validator with the corrected lint

Assisted-by: Claude Opus 4.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants