Skip to content

refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer() #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 2 commits into from
Closed

refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer() #6361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e57e8e
refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer()
cjihrig Feb 1, 2026
6870764
Apply suggestion from @cjihrig
cjihrig Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ feat(configuration): parse config for rc 3 [#6304](https://github.com/open-telem
### :house: Internal

* perf(otlp-transformer): optimize toAnyValue performance [#6287](https://github.com/open-telemetry/opentelemetry-js/pull/6287) @AbhiPrasad
* refactor(sdk-logs): remove unnecessary closure in \_maybeStartTimer() [#xxxx](https://github.com/open-telemetry/opentelemetry-js/pull/xxxx) @cjihrig
Comment thread
cjihrig marked this conversation as resolved.
Outdated

## 0.211.0

Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export abstract class BatchLogRecordProcessorBase<T extends BufferConfig>
return flush();
}
if (this._timer !== undefined) return;
this._timer = setTimeout(() => flush(), this._scheduledDelayMillis);
this._timer = setTimeout(flush, this._scheduledDelayMillis);
// depending on runtime, this may be a 'number' or NodeJS.Timeout
if (typeof this._timer !== 'number') {
this._timer.unref();
Expand Down