Skip to content

fix(sdk-trace-web): propagate optimised flag in getElementXPath recursion #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 4 commits into from
Feb 23, 2026
Merged

fix(sdk-trace-web): propagate optimised flag in getElementXPath recursion #6335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4005d1c
fix(sdk-trace-web): preserve optimised XPath recursion
akkupratap323 Jan 23, 2026
3760ad2
fix(sdk-trace-web): address review feedback on XPath test
akkupratap323 Jan 25, 2026
9b631b3
test(sdk-trace-web): use fixture for recursive getElementXPath test
pichlermarc Feb 23, 2026
3b70d86
chore: add changelog entry
pichlermarc Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2

### :bug: Bug Fixes

* fix(sdk-trace-web): propagate `optimised` flag in `getElementXPath` recursion [#6335](https://github.com/open-telemetry/opentelemetry-js/pull/6335) @akkupratap323

### :books: Documentation

### :house: Internal
Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-sdk-trace-web/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ export function getElementXPath(target: any, optimised?: boolean): string {
}
let xpath = '';
if (target.parentNode) {
xpath += getElementXPath(target.parentNode, false);
xpath += getElementXPath(target.parentNode, optimised);
}
xpath += targetValue;

Expand Down
8 changes: 8 additions & 0 deletions packages/opentelemetry-sdk-trace-web/test/window/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ const fixture = `
<div></div>
</div>
<div></div>
<div id="body-id"><div></div></div>
</div>
`;

Expand Down Expand Up @@ -92,6 +93,13 @@ describe('utils', function () {
);
});

it('should use ancestor id when optimised recursively', function () {
const inner = $fixture.find('#body-id div')[0];
const element = getElementXPath(inner, true);
assert.strictEqual(element, '//*[@id="body-id"]/div');
assert.strictEqual(inner, getElementByXpath(element));
});

it(
'should return correct path for element with id and surrounded by the' +
' same type',
Expand Down