Skip to content

fix(exporter-prometheus): add missing semantic-conventions dependency#6330

Merged
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
omizha:fix/prometh
Jan 27, 2026
Merged

fix(exporter-prometheus): add missing semantic-conventions dependency#6330
pichlermarc merged 2 commits intoopen-telemetry:mainfrom
omizha:fix/prometh

Conversation

@omizha
Copy link
Copy Markdown
Contributor

@omizha omizha commented Jan 22, 2026

Which problem is this PR solving?

The withoutScopeInfo feature added in #5993 imports ATTR_OTEL_SCOPE_NAME and ATTR_OTEL_SCOPE_VERSION from
@opentelemetry/semantic-conventions at runtime, but the package was only listed in devDependencies.

This causes module resolution errors when using the exporter in projects with strict dependency resolution (e.g.,
Yarn PnP):

Error: @opentelemetry/exporter-prometheus tried to access @opentelemetry/semantic-conventions,
but it isn't declared in its dependencies

Short description of the changes

Move @opentelemetry/semantic-conventions from devDependencies to dependencies in
experimental/packages/opentelemetry-exporter-prometheus/package.json.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • All existing unit tests pass (62 passing)

npm run test -w @opentelemetry/exporter-prometheus

62 passing (68ms)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@omizha omizha requested a review from a team as a code owner January 22, 2026 16:16
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 22, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (0fd543c) to head (666373b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6330   +/-   ##
=======================================
  Coverage   95.58%   95.59%           
=======================================
  Files         314      314           
  Lines        9590     9596    +6     
  Branches     2221     2221           
=======================================
+ Hits         9167     9173    +6     
  Misses        423      423           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc added this pull request to the merge queue Jan 27, 2026
Merged via the queue into open-telemetry:main with commit 2926172 Jan 27, 2026
27 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Jan 27, 2026

Thank you for your contribution @omizha! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants