Skip to content

test(sdk-trace-base): remove obsolete TypeScript and platform workarounds#6327

Merged
pichlermarc merged 3 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/trace-cleanup
Jan 22, 2026
Merged

test(sdk-trace-base): remove obsolete TypeScript and platform workarounds#6327
pichlermarc merged 3 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/trace-cleanup

Conversation

@overbalance
Copy link
Copy Markdown
Contributor

@overbalance overbalance commented Jan 21, 2026

Which problem is this PR solving?

Test files contain outdated workarounds for TypeScript < 4.6 and unnecessary platform detection logic.

Short description of the changes

  • Remove WebVisibilityState type alias - TypeScript 4.6+ provides DocumentVisibilityState natively
  • Replace describeDocument conditional with describeBrowser used elsewhere
  • Simplify Node test env setup by removing global.process?.versions?.node check - unnecessary in test/node/

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing unit tests pass

Checklist:

  • Followed the style guidelines of this project

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.58%. Comparing base (e5f2d42) to head (2a4e63a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6327   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         314      314           
  Lines        9590     9590           
  Branches     2221     2221           
=======================================
  Hits         9167     9167           
  Misses        423      423           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance overbalance force-pushed the overbalance/trace-cleanup branch from 7b44633 to b59be52 Compare January 21, 2026 23:26
@overbalance overbalance force-pushed the overbalance/trace-cleanup branch from b59be52 to 37ed460 Compare January 21, 2026 23:27
@overbalance overbalance marked this pull request as ready for review January 21, 2026 23:38
@overbalance overbalance requested a review from a team as a code owner January 21, 2026 23:38
@pichlermarc pichlermarc added this pull request to the merge queue Jan 22, 2026
Merged via the queue into open-telemetry:main with commit 0fd543c Jan 22, 2026
27 checks passed
@overbalance overbalance deleted the overbalance/trace-cleanup branch January 22, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants