Skip to content

refactor(sdk-logs): simplify _export() #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 2 commits into from
Jan 20, 2026
Merged

refactor(sdk-logs): simplify _export() #6318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4cde0
refactor(sdk-logs): simplify _export()
cjihrig Jan 20, 2026
2dc0a2d
Apply suggestion from @cjihrig
cjihrig Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
### :house: Internal

* fix(build): update @types/node to 18.19.130, remove DOM types from base tsconfig [#6280](https://github.com/open-telemetry/opentelemetry-js/pull/6280) @overbalance
* refactor(sdk-logs): simplify \_export() [#xxxx](https://github.com/open-telemetry/opentelemetry-js/pull/xxxx) @cjihrig
Comment thread
cjihrig marked this conversation as resolved.
Outdated

## 0.210.0

Expand Down
18 changes: 12 additions & 6 deletions experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,23 @@ export abstract class BatchLogRecordProcessorBase<T extends BufferConfig>
})
.catch(globalErrorHandler);

const pendingResources = logRecords
.map(logRecord => logRecord.resource)
.filter(resource => resource.asyncAttributesPending);
const pendingResources = [];

for (let i = 0; i < logRecords.length; i++) {
const resource = logRecords[i].resource;
if (
resource.asyncAttributesPending &&
typeof resource.waitForAsyncAttributes === 'function'
) {
pendingResources.push(resource.waitForAsyncAttributes());
}
}

// Avoid scheduling a promise to make the behavior more predictable and easier to test
if (pendingResources.length === 0) {
return doExport();
} else {
return Promise.all(
pendingResources.map(resource => resource.waitForAsyncAttributes?.())
).then(doExport, globalErrorHandler);
return Promise.all(pendingResources).then(doExport, globalErrorHandler);
}
}

Expand Down