Skip to content

chore: move catch-all rule to top of CODEOWNERS#6297

Merged
overbalance merged 1 commit intoopen-telemetry:mainfrom
embrace-io:overbalance/fix-codeowners
Jan 14, 2026
Merged

chore: move catch-all rule to top of CODEOWNERS#6297
overbalance merged 1 commit intoopen-telemetry:mainfrom
embrace-io:overbalance/fix-codeowners

Conversation

@overbalance
Copy link
Copy Markdown
Contributor

@overbalance overbalance commented Jan 14, 2026

Summary

  • Moves the catch-all * @open-telemetry/javascript-approvers rule from the bottom to the top of CODEOWNERS
  • CODEOWNERS rules are matched top-to-bottom with later rules taking precedence, so the catch-all must be first for specific rules to properly override it

Test plan

  • Verify that PRs touching .github/ files require javascript-maintainers approval
  • Verify that PRs touching browser packages require browser-maintainers approval

Verification

Observe that this PR modifies .github/ but only @open-telemetry/javascript-approvers are tagged for review.

Screenshot 2026-01-14 at 12 02 24 PM

@overbalance overbalance requested a review from a team as a code owner January 14, 2026 18:01
CODEOWNERS rules are matched top-to-bottom with later rules taking
precedence. The catch-all `*` rule must be first so specific rules
for .github/ and browser packages can properly override it.
@overbalance overbalance changed the title fix: move catch-all rule to top of CODEOWNERS chore: move catch-all rule to top of CODEOWNERS Jan 14, 2026
@overbalance overbalance force-pushed the overbalance/fix-codeowners branch from ffc64a8 to 16d91e3 Compare January 14, 2026 18:04
@overbalance overbalance enabled auto-merge January 14, 2026 18:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.39%. Comparing base (5e6504d) to head (16d91e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6297   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         316      316           
  Lines        9574     9574           
  Branches     2216     2216           
=======================================
  Hits         9133     9133           
  Misses        441      441           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance overbalance added this pull request to the merge queue Jan 14, 2026
Merged via the queue into open-telemetry:main with commit 118f5b5 Jan 14, 2026
27 checks passed
@overbalance overbalance deleted the overbalance/fix-codeowners branch January 14, 2026 18:21
maryliag pushed a commit to maryliag/opentelemetry-js that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants