-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: deploy documentation on releases #629
ci: deploy documentation on releases #629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 90.49% 90.25% -0.25%
==========================================
Files 181 189 +8
Lines 9209 9602 +393
Branches 819 876 +57
==========================================
+ Hits 8334 8666 +332
- Misses 875 936 +61
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few maintenance related questions.
@open-telemetry/javascript-approvers we need more reviews for this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last question: what will be the domain name for gh-pages(documentation) after last change?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent 🚀🚀
@mayurkale22 now that this is merged, someone with access to settings has to enable gh-pages. I don't have access. |
Even I don't have access to settings tab, maybe @tedsuo can help here. |
I asked in gitter, but nobody responded |
* chore: sorting packages owners alphabetically * chore: adding myself for few packages as owner
Which problem is this PR solving?
Short description of the changes
/^v\d+\.\d+\.\d+$/
regex is pushed