fix(config): do not set propagators by default#6234
Closed
yoursanonymous wants to merge 3 commits intoopen-telemetry:mainfrom
Closed
fix(config): do not set propagators by default#6234yoursanonymous wants to merge 3 commits intoopen-telemetry:mainfrom
yoursanonymous wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
maryliag
reviewed
Dec 18, 2025
| }); | ||
| }); | ||
|
|
||
| it('should set propagators from OTEL_PROPAGATORS when defined', () => { |
Contributor
There was a problem hiding this comment.
this file focus on testing functions from the utils file, which is not the case for this test, so you can remove from here and update the ConfigFactory.test.js file accordingly
maryliag
reviewed
Dec 18, 2025
| const rawValue = keyPairPart.substring(separatorIndex + 1).trim(); | ||
|
|
||
| if (!rawKey || !rawValue) return; | ||
| if (!rawKey) return; |
Contributor
There was a problem hiding this comment.
can you explain the rationale behind this change and the one below? they don't seem related to your PR topic
Contributor
There was a problem hiding this comment.
I can see these changes are from your other PR, so please remove them from here
Contributor
|
Hey @yoursanonymous , friendly ping to check fi you still plan on working on this |
11 tasks
Contributor
|
Closing in favor of #6399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR fixes an issue where
initializeDefaultConfiguration()implicitly configured text map propagators by default.Fixes #6150
Short description of the changes
Removed default propagator configuration from
initializeDefaultConfigurationAdded a unit test to ensure propagators are not set by default
Added a unit test to verify propagators are configured when
OTEL_PROPAGATORSis explicitly definedType of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests covering default and environment-based propagator behavior
Tests executed locally using: npx mocha test/utils.test.ts
Checklist: