revert(otlp-transformer): undo migration to protobuf-es#6225
Merged
overbalance merged 5 commits intoopen-telemetry:mainfrom Dec 17, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6225 +/- ##
==========================================
- Coverage 95.40% 95.40% -0.01%
==========================================
Files 317 317
Lines 9540 9518 -22
Branches 2205 2194 -11
==========================================
- Hits 9102 9081 -21
+ Misses 438 437 -1
🚀 New features to boost your workflow:
|
…protobuf-es-use-patched-protobufjs
trentm
reviewed
Dec 17, 2025
Contributor
trentm
left a comment
There was a problem hiding this comment.
Looks good. Thanks for having this ready. I didn't check carefully that it restored the state before.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
Contributor
There was a problem hiding this comment.
This is odd, but it was indeed in the original state of the file.
Contributor
Author
There was a problem hiding this comment.
I rolled back the commits verbatim. This quirk was restored along with a few unused tsconfig variables.
trentm
approved these changes
Dec 17, 2025
Contributor
|
Approved, though this is still in draft. Discussion on whether we want this (we do) is here: #6221 (comment) |
JamieDanielson
approved these changes
Dec 17, 2025
…protobuf-es-use-patched-protobufjs
5 tasks
3 tasks
intech
added a commit
to Connectum-Framework/connectum
that referenced
this pull request
Apr 19, 2026
…101) ## Summary - Adds Performance Characteristics section to @connectum/otel README - Documents OTLP protobuf serializer status per signal (logs/traces/metrics) - Explains otlp-transformer version pin rationale - Provides guidance for high-volume span workloads ## Context OTel JS attempted to migrate otlp-transformer to @bufbuild/protobuf in [PR #6179](open-telemetry/opentelemetry-js#6179) but reverted in [PR #6225](open-telemetry/opentelemetry-js#6225) due to ~13x serialization slowdown (see [issue #6221](open-telemetry/opentelemetry-js#6221)). Hand-rolled ProtobufLogsSerializer landed in v0.215.0 via [PR #6390](open-telemetry/opentelemetry-js#6390); traces and metrics migrations are still pending (see [#6570](open-telemetry/opentelemetry-js#6570)). This doc makes the current state explicit for @connectum/otel consumers. ## Test plan - [x] Markdown renders correctly (biome check passes) - [x] Links to upstream issues/PRs resolve - [x] No impact on package code 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for discussion of issue #6221
Protobuf revert
@typescript/vfspeer dependency to instrumentation-grpcTest plan