Skip to content

revert(otlp-transformer): undo migration to protobuf-es#6225

Merged
overbalance merged 5 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/revert-protobuf-es-use-patched-protobufjs
Dec 17, 2025
Merged

revert(otlp-transformer): undo migration to protobuf-es#6225
overbalance merged 5 commits intoopen-telemetry:mainfrom
embrace-io:overbalance/revert-protobuf-es-use-patched-protobufjs

Conversation

@overbalance
Copy link
Copy Markdown
Contributor

@overbalance overbalance commented Dec 16, 2025

PR for discussion of issue #6221

Protobuf revert

  • Revert the migration to protobuf-es in otlp-transformer package
  • Add missing @typescript/vfs peer dependency to instrumentation-grpc

Test plan

  • Run existing unit tests
  • Verify protobuf serialization works correctly
  • Run benchmark to confirm performance characteristics

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (b616ae1) to head (3383d59).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6225      +/-   ##
==========================================
- Coverage   95.40%   95.40%   -0.01%     
==========================================
  Files         317      317              
  Lines        9540     9518      -22     
  Branches     2205     2194      -11     
==========================================
- Hits         9102     9081      -21     
+ Misses        438      437       -1     
Files with missing lines Coverage Δ
...ntal/packages/otlp-transformer/src/common/utils.ts 100.00% <100.00%> (+2.43%) ⬆️
...tal/packages/otlp-transformer/src/logs/internal.ts 100.00% <100.00%> (ø)
...ackages/otlp-transformer/src/logs/protobuf/logs.ts 100.00% <100.00%> (ø)
.../packages/otlp-transformer/src/metrics/internal.ts 100.00% <100.00%> (ø)
...s/otlp-transformer/src/metrics/protobuf/metrics.ts 100.00% <100.00%> (ø)
...al/packages/otlp-transformer/src/trace/internal.ts 98.59% <100.00%> (ø)
...kages/otlp-transformer/src/trace/protobuf/trace.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@overbalance overbalance changed the title revert(otlp-transformer): migration to protobuf-es revert(otlp-transformer): undo migration to protobuf-es Dec 16, 2025
Copy link
Copy Markdown
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for having this ready. I didn't check carefully that it restored the state before.

* See the License for the specific language governing permissions and
* limitations under the License.
*/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd, but it was indeed in the original state of the file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back the commits verbatim. This quirk was restored along with a few unused tsconfig variables.

@trentm
Copy link
Copy Markdown
Contributor

trentm commented Dec 17, 2025

Approved, though this is still in draft. Discussion on whether we want this (we do) is here: #6221 (comment)

@overbalance overbalance marked this pull request as ready for review December 17, 2025 20:43
@overbalance overbalance added this pull request to the merge queue Dec 17, 2025
Merged via the queue into open-telemetry:main with commit d33623e Dec 17, 2025
27 checks passed
@overbalance overbalance deleted the overbalance/revert-protobuf-es-use-patched-protobufjs branch December 17, 2025 20:51
intech added a commit to Connectum-Framework/connectum that referenced this pull request Apr 19, 2026
…101)

## Summary
- Adds Performance Characteristics section to @connectum/otel README
- Documents OTLP protobuf serializer status per signal
(logs/traces/metrics)
- Explains otlp-transformer version pin rationale
- Provides guidance for high-volume span workloads

## Context
OTel JS attempted to migrate otlp-transformer to @bufbuild/protobuf in
[PR #6179](open-telemetry/opentelemetry-js#6179)
but reverted in [PR
#6225](open-telemetry/opentelemetry-js#6225) due
to ~13x serialization slowdown (see [issue
#6221](open-telemetry/opentelemetry-js#6221)).
Hand-rolled ProtobufLogsSerializer landed in v0.215.0 via [PR
#6390](open-telemetry/opentelemetry-js#6390);
traces and metrics migrations are still pending (see
[#6570](open-telemetry/opentelemetry-js#6570)).

This doc makes the current state explicit for @connectum/otel consumers.

## Test plan
- [x] Markdown renders correctly (biome check passes)
- [x] Links to upstream issues/PRs resolve
- [x] No impact on package code

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants