Skip to content

refactor(configuration): dont have a default value for node resource detectors #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieDanielson merged 2 commits into from
Nov 19, 2025
Merged

refactor(configuration): dont have a default value for node resource detectors #6131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ab46b
dont have default for node resource detectors
maryliag Nov 19, 2025
e4e85a3
Merge branch 'main' into default-resources
JamieDanielson Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
* feat(configuration): set tracer provider exporter type from env variables [#6106](https://github.com/open-telemetry/opentelemetry-js/pull/6106) @maryliag
* feat(configuration): set meter provider exporter type from env variable [#6105](https://github.com/open-telemetry/opentelemetry-js/pull/6105) @maryliag
* refactor(configuration): throw warning and not error for invalid files [#6124](https://github.com/open-telemetry/opentelemetry-js/pull/6124) @maryliag
* refactor(configuration): dont have a default value for node resource detectors [#x](https://github.com/open-telemetry/opentelemetry-js/pull/x) @maryliag

### :bug: Bug Fixes

Expand Down
1 change: 0 additions & 1 deletion experimental/packages/configuration/src/models/configModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ export function initializeDefaultConfiguration(): ConfigurationModel {
const config: ConfigurationModel = {
disabled: false,
log_level: DiagLogLevel.INFO,
node_resource_detectors: ['all'],
resource: {},
attribute_limits: {
attribute_count_limit: 128,
Expand Down
3 changes: 0 additions & 3 deletions experimental/packages/configuration/test/ConfigFactory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import {
const defaultConfig: ConfigurationModel = {
disabled: false,
log_level: DiagLogLevel.INFO,
node_resource_detectors: ['all'],
resource: {},
attribute_limits: {
attribute_count_limit: 128,
Expand Down Expand Up @@ -140,7 +139,6 @@ const defaultConfig: ConfigurationModel = {
const configFromFile: ConfigurationModel = {
disabled: false,
log_level: DiagLogLevel.INFO,
node_resource_detectors: ['all'],
resource: {
schema_url: 'https://opentelemetry.io/schemas/1.16.0',
attributes_list: 'service.namespace=my-namespace,service.version=1.0.0',
Expand Down Expand Up @@ -631,7 +629,6 @@ const configFromFile: ConfigurationModel = {
const defaultConfigFromFileWithEnvVariables: ConfigurationModel = {
disabled: false,
log_level: DiagLogLevel.INFO,
node_resource_detectors: ['all'],
resource: {
attributes: [
{
Expand Down