Skip to content

feat(configuration): doesnt set meter, tracer, logger provider by default#6130

Merged
maryliag merged 11 commits intoopen-telemetry:mainfrom
maryliag:default-providers
Nov 21, 2025
Merged

feat(configuration): doesnt set meter, tracer, logger provider by default#6130
maryliag merged 11 commits intoopen-telemetry:mainfrom
maryliag:default-providers

Conversation

@maryliag
Copy link
Copy Markdown
Contributor

@maryliag maryliag commented Nov 19, 2025

@maryliag maryliag requested a review from a team as a code owner November 19, 2025 02:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 98.04401% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.39%. Comparing base (3110287) to head (4051f21).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...al/packages/configuration/src/FileConfigFactory.ts 93.33% 6 Missing ⚠️
...ages/configuration/src/EnvironmentConfigFactory.ts 99.37% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6130      +/-   ##
==========================================
+ Coverage   95.21%   95.39%   +0.17%     
==========================================
  Files         316      316              
  Lines        9389     9374      -15     
  Branches     2167     2166       -1     
==========================================
+ Hits         8940     8942       +2     
+ Misses        449      432      -17     
Files with missing lines Coverage Δ
...l/packages/configuration/src/models/configModel.ts 100.00% <ø> (ø)
...es/configuration/src/models/loggerProviderModel.ts 100.00% <ø> (ø)
...ges/configuration/src/models/meterProviderModel.ts 100.00% <ø> (ø)
...es/configuration/src/models/tracerProviderModel.ts 100.00% <ø> (ø)
...ages/configuration/src/EnvironmentConfigFactory.ts 99.06% <99.37%> (-0.02%) ⬇️
...al/packages/configuration/src/FileConfigFactory.ts 96.85% <93.33%> (+2.80%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/packages/configuration/src/FileConfigFactory.ts
Comment thread experimental/packages/configuration/src/FileConfigFactory.ts Outdated
Comment thread experimental/packages/configuration/src/FileConfigFactory.ts
Copy link
Copy Markdown
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for warning on empty arrays. I think the rest looks good! 🚀

Comment thread experimental/packages/configuration/test/fixtures/invalid-providers.yaml Outdated
Comment thread experimental/packages/configuration/src/FileConfigFactory.ts Outdated
@maryliag maryliag added this pull request to the merge queue Nov 21, 2025
Merged via the queue into open-telemetry:main with commit c071e6e Nov 21, 2025
27 checks passed
@maryliag maryliag deleted the default-providers branch November 21, 2025 01:20
@otelbot-js otelbot-js Bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[config] Disable tracer/meter/logger providers by default

2 participants