Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-dns): remove from default plugin list #613

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/opentelemetry-node/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export interface NodeTracerConfig extends BasicTracerConfig {
/** List of all default supported plugins */
export const DEFAULT_INSTRUMENTATION_PLUGINS: Plugins = {
'mongodb-core': { enabled: true, path: '@opentelemetry/plugin-mongodb-core' },
dns: { enabled: true, path: '@opentelemetry/plugin-dns' },
grpc: { enabled: true, path: '@opentelemetry/plugin-grpc' },
http: { enabled: true, path: '@opentelemetry/plugin-http' },
https: { enabled: true, path: '@opentelemetry/plugin-https' },
Expand Down
17 changes: 17 additions & 0 deletions packages/opentelemetry-plugin-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,23 @@ const tracer = new NodeTracer({
});
```

### Zipkin

If you use Zipkin, you must use `ignoreHostnames` in order to not trace those calls. If the server is local. You can set :

```
const tracer = new NodeTracer({
plugins: {
dns: {
enabled: true,
// You may use a package name or absolute path to the file.
path: '@opentelemetry/plugin-dns',
ignoreHostnames: ['localhost']
}
}
});
```

### Dns Plugin Options

Dns plugin has currently one option. You can set the following:
Expand Down