test(sdk-node): use process.env consistently in tests

[cjihrig]

Which problem is this PR solving?

sdk.test.ts in sdk-node appears to be the only place in the codebase that uses a destructured process.env. It even does so inconsistently within the file.

Fixes # N/A

Short description of the changes

This commit updates the test file to use process.env consistently.

Type of change

None of the items in this list really apply.

How Has This Been Tested?

• Existing test suite.

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (74f470e) to head (e231a7d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6052   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         316      316           
  Lines        9198     9207    +9     
  Branches     2057     2075   +18     
=======================================
+ Hits         8753     8762    +9     
  Misses        445      445           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[david-luna]

Process is already in the global scope https://nodejs.org/api/globals.html#process so I think it is safe to remove this line. Also I think this import opens a door to load a package if installed (https://www.npmjs.com/package/process)

[cjihrig]

Yea, I wasn't sure why it was explicitly imported, so I left it there. I have removed it now. FWIW, process is imported in other places in the codebase.

Also I think this import opens a door to load a package if installed

The preferred way to guard against this is to import Node core modules with the node: prefix (for example, node:fs instead of fs). Newer core modules actually requires the prefix (for example, node:sqlite would work, but sqlite would not).

[otelbot]

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.