chore: skip npmjs.com in linkchecking while it returns 403 to non-browsers#5948
Merged
maryliag merged 2 commits intoopen-telemetry:mainfrom Sep 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 308 308
Lines 8037 8037
Branches 1626 1626
=======================================
Hits 7641 7641
Misses 396 396 🚀 New features to boost your workflow:
|
Contributor
Author
|
As expected, the Lint workflow fails (as it is doing with other PRs today): |
Contributor
Author
|
I've asked in npm discussions if this is intentional, FWIW: https://github.com/orgs/community/discussions/174098 Not sure if that is a reasonable forum. https://www.npmjs.com/support says:
|
5 tasks
maryliag
approved these changes
Sep 19, 2025
Contributor
|
thanks for fixing this, it was annoying 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#5839 (comment) for background.)
npmjs.com is returning 403s for link checks. This breaks linting (in the
npm run docs:teststep). For example: