Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add discussion issue type #592

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Dec 5, 2019

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #592 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #592     +/-   ##
=========================================
+ Coverage   91.76%   91.87%   +0.1%     
=========================================
  Files         169      169             
  Lines        8090     8206    +116     
  Branches      716      719      +3     
=========================================
+ Hits         7424     7539    +115     
- Misses        666      667      +1
Impacted Files Coverage Δ
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/ConsoleSpanExporter.test.ts 100% <0%> (ø) ⬆️
...ntelemetry-tracing/test/MultiSpanProcessor.test.ts 100% <0%> (ø) ⬆️
... and 4 more

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mayurkale22 mayurkale22 merged commit 5ab4f13 into open-telemetry:master Dec 5, 2019
@dyladan dyladan deleted the discussion-issue branch December 6, 2019 10:27
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants