chore(deps): update dependency markdownlint-cli2 to v0.18.1

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
markdownlint-cli2	0.17.2 -> 0.18.1

---

Release Notes

DavidAnson/markdownlint-cli2 (markdownlint-cli2)

v0.18.1

Compare Source

• Update dependencies (including markdownlint)

v0.18.0

Compare Source

• Use user ID in Docker containers for security
• Update dependencies (including markdownlint)
• Remove support for end-of-life Node 18

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.06%. Comparing base (ea83923) to head (cd5c0cf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5891   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         307      307           
  Lines        8031     8031           
  Branches     1627     1627           
=======================================
  Hits         7635     7635           
  Misses        396      396           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[trentm]

npm run lint:markdown is failing:

CHANGELOG.md:174:57 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
CHANGELOG.md:177:57 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
CONTRIBUTING.md:87:369 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
doc/upgrade-to-2.x.md:211:296 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
...

because markdownlint-cli2 added a new MD059/descriptive-link-text check (DavidAnson/markdownlint-cli2@ba5646f#diff-1876ef6ac21e1058f5e88387385d548e03695520436667aa019fab3d2bf8b886R1786-R1787):

    "MD059": {
      "description": "MD059/descriptive-link-text : Link text should be descriptive : https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md059.md",
      "type": [
        "boolean",
        "object"
      ],
      "default": true,
      "properties": {
        "prohibited_texts": {
          "description": "Prohibited link texts",
          "type": "array",
          "items": {
            "type": "string"
          },
          "default": [
            "click here",
            "here",
            "link",
            "more"
          ]
        }
      },
      "additionalProperties": false
    },

The check doesn't like specific generic words/phrases as the link text. E.g. More info on Widgets can be found [here](https://example.com). is now bad.

[trentm]

The relevant change is the transitive update to [email protected]: https://github.com/DavidAnson/markdownlint/blob/main/CHANGELOG.md#0380

The rule is documented here: https://github.com/DavidAnson/markdownlint/blob/main/doc/md059.md

This is for better a11y.

[trentm]

The second concern is that Node.js v18 support has been dropped. This isn't an issue for CI (which uses Node.js v22), but perhaps an annoyance for a developer attempting to use v18. v18 is out of LTS so I don't think we need to maintain lint working for those cases. I'll do this as a hint in case this ever breaks for someone locally:

diff --git a/package.json b/package.json
index 265bf8174..c2e7d4026 100644
--- a/package.json
+++ b/package.json
@@ -26,8 +26,8 @@
     "lint:fix:changed": "lerna run --concurrency 1 --stream lint:fix --since HEAD --exclude-dependents",
     "lint:examples": "eslint --no-error-on-unmatched-pattern ./examples/**/*.js",
     "lint:examples:fix": "eslint --no-error-on-unmatched-pattern ./examples/**/*.js --fix",
-    "lint:markdown": "markdownlint-cli2 $(git ls-files '*.md')",
-    "lint:markdown:fix": "markdownlint-cli2 --fix $(git ls-files '*.md')",
+    "lint:markdown": "markdownlint-cli2 $(git ls-files '*.md')  # requires Node.js >=20",
+    "lint:markdown:fix": "markdownlint-cli2 --fix $(git ls-files '*.md')  # requires Node.js >=20",
     "lint:semconv-deps": "./scripts/lint-semconv-deps.mjs",
     "reset": "lerna clean -y && rm -rf node_modules && npm i && npm run compile && npm run lint:fix",
     "update-ts-configs": "node scripts/update-ts-configs.js",

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[trentm]

lint:markdown fails as follows in CI, but not locally:

 > [email protected] lint:markdown
> markdownlint-cli2 $(git ls-files '*.md')  # requires Node.js >=20

.github/ISSUE_TEMPLATE/discussion.md:14:270 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
.github/ISSUE_TEMPLATE/feature_request.md:25:270 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]
.github/ISSUE_TEMPLATE/request_for_instrumentation.md:31:270 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]

I've no idea why.

[trentm]

I've no idea why.

Hah! It is because of the "subscript" thing that is added to the content of these files (from #5831):

...
<sub>**Tip**: [React](https://github.blog/news-insights/product-news/add-reactions-to-pull-requests-issues-and-comments/) with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding `+1` or `me too`, to help us triage it. Learn more [here](https://opentelemetry.io/community/end-user/issue-participation/).</sub>

... and that didn't fail locally because the subscript thing just went in and this branch isn't updated. sigh.

[opentelemetrybot]

Thank you for your contribution @renovate[bot]! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.