feat(opentelemetry-configuration): Parse of Configuration File#5875
Merged
pichlermarc merged 23 commits intoopen-telemetry:mainfrom Sep 23, 2025
Merged
feat(opentelemetry-configuration): Parse of Configuration File#5875pichlermarc merged 23 commits intoopen-telemetry:mainfrom
pichlermarc merged 23 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5875 +/- ##
==========================================
+ Coverage 95.10% 95.14% +0.03%
==========================================
Files 315 316 +1
Lines 8396 8457 +61
Branches 1727 1747 +20
==========================================
+ Hits 7985 8046 +61
Misses 411 411
🚀 New features to boost your workflow:
|
pichlermarc
reviewed
Sep 16, 2025
Member
pichlermarc
left a comment
There was a problem hiding this comment.
Sorry for taking so long to get to this one - I'll have a look at the second one soon.
…igProvider.ts Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
trentm
reviewed
Sep 17, 2025
Contributor
|
Note the lint failure here with linkinator failing (in |
… sampling spec (open-telemetry#5839) Co-authored-by: Trent Mick <trentm@gmail.com>
…omposite sampling spec (open-telemetry#5839)" This reverts commit a662970.
pichlermarc
reviewed
Sep 22, 2025
Member
pichlermarc
left a comment
There was a problem hiding this comment.
A few more comments - after these, this is good to merge 🙂
Contributor
Author
|
@pichlermarc all comments addressed, let me know if you want any other changes |
pichlermarc
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part Of #5813
Parse a yaml/yml file and populate the corresponding parameters on config model
Parse of remaining items can be done once #5862 is merged