Skip to content

chore(core): remove unneeded file sampling.ts#5841

Merged
pichlermarc merged 1 commit intoopen-telemetry:mainfrom
Flarna:core-rm-sampling
Aug 12, 2025
Merged

chore(core): remove unneeded file sampling.ts#5841
pichlermarc merged 1 commit intoopen-telemetry:mainfrom
Flarna:core-rm-sampling

Conversation

@Flarna
Copy link
Copy Markdown
Member

@Flarna Flarna commented Aug 8, 2025

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Flarna Flarna requested a review from a team as a code owner August 8, 2025 11:18
@Flarna
Copy link
Copy Markdown
Member Author

Flarna commented Aug 8, 2025

Is a changelog needed for this?

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (549e0a6) to head (f789c3e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5841   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         303      303           
  Lines        7943     7943           
  Branches     1607     1607           
=======================================
  Hits         7547     7547           
  Misses        396      396           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc
Copy link
Copy Markdown
Member

Is a changelog needed for this?

not needed - thank you for removing this 🙌

@pichlermarc pichlermarc added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@pichlermarc pichlermarc added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@pichlermarc
Copy link
Copy Markdown
Member

tests are failing for unrelated reasons, #5851 will address the failing tests this while we figure out what's wrong with #5850.

@pichlermarc pichlermarc added this pull request to the merge queue Aug 12, 2025
Merged via the queue into open-telemetry:main with commit c7796f7 Aug 12, 2025
25 of 26 checks passed
@Flarna Flarna deleted the core-rm-sampling branch August 12, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants