-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named Tracers / Tracer Registry #582
Merged
mayurkale22
merged 37 commits into
open-telemetry:master
from
dynatrace-oss-contrib:tracer-registry
Jan 9, 2020
Merged
Changes from 11 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
d75f53e
feat: spike of named tracer registry
dyladan ead9f16
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 50927cd
chore: mysql/mongo tracer registry support
dyladan c686117
fix: lint
dyladan 7dba62c
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 14fa061
chore: add getTracer back
dyladan b1e887c
chore: change default tracer name to empty string
dyladan 5ca0209
fix: lint
dyladan 217d3b3
Merge branch 'master' into tracer-registry
dyladan 61f4618
chore: update examples for registry
dyladan 33dd773
Merge branch 'tracer-registry' of github.com:dynatrace-oss-contrib/op…
dyladan 6f81608
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 0687f1c
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan cc4eba9
chore(tracer-registry): make name required
dyladan 9d95597
chore: lint
dyladan 3237f99
chore: update examples for required tracer name
dyladan 643e286
chore: remove unused tracer delegate
dyladan 508ff33
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 41c1168
chore: remove references to basic tracer
dyladan 6a94efe
chore: remove references to NodeTracer
dyladan 4693d22
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 13f96fd
chore: update xhr for tracer registry
dyladan 38ffef8
chore: update tracer names to match package names
dyladan 9915a2c
chore: add version script to all packages
dyladan 69ff01f
chore: update plugins to use version script
dyladan 40c4301
chore: add jsdoc to noop tracer registry
dyladan 1eea9d2
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 660f41f
chore: update ioredis for tracer registry
dyladan 8e6399e
chore: update pg pool for tracer registry
dyladan bd0be2c
fix: lint
dyladan 30a1b36
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan 7c39151
chore: fix tests
dyladan e814df6
chore: lint
dyladan 0ec5b82
Merge remote-tracking branch 'upstream/master' into tracer-registry
dyladan cd47354
chore: lint
dyladan bfa8bfa
Merge branch 'master' into tracer-registry
mayurkale22 5740098
Merge branch 'master' into tracer-registry
mayurkale22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,6 +71,7 @@ docs | |
|
||
#lerna | ||
.changelog | ||
package.json.lerna_backup | ||
|
||
# OS generated files | ||
.DS_Store | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
packages/opentelemetry-core/src/trace/NoopTracerRegistry.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/*! | ||
* Copyright 2019, OpenTelemetry Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import * as types from '@opentelemetry/types'; | ||
import { noopTracer } from './NoopTracer'; | ||
|
||
export class NoopTracerRegistry implements types.TracerRegistry { | ||
dyladan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
getTracer(_name?: string, _version?: string): types.Tracer { | ||
return noopTracer; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentional ?