Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing main in package.json #577

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

hieven
Copy link
Contributor

@hieven hieven commented Nov 28, 2019

Which problem is this PR solving?

  • Add missing main to package.json

Short description of the changes

  • Missing main in package.json makes developer unable to do require("@opentelemetry/shim-opentracing");

Screen Shot 2019-11-28 at 23 00 42

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #577 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #577      +/-   ##
=========================================
- Coverage   90.54%   90.5%   -0.05%     
=========================================
  Files         156     155       -1     
  Lines        8019    8004      -15     
  Branches      692     704      +12     
=========================================
- Hits         7261    7244      -17     
- Misses        758     760       +2
Impacted Files Coverage Δ
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...core/src/context/propagation/BinaryTraceContext.ts 96.72% <0%> (-1.62%) ⬇️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-core/src/trace/globaltracer-utils.ts 100% <0%> (ø) ⬆️
... and 7 more

@OlivierAlbertini OlivierAlbertini added the bug Something isn't working label Nov 30, 2019
@OlivierAlbertini OlivierAlbertini merged commit 566452e into open-telemetry:master Nov 30, 2019
@hieven hieven deleted the fix-missing-main branch November 30, 2019 15:00
hieven added a commit to hieven/opentelemetry-js that referenced this pull request Nov 30, 2019
fix(shim-opentracing): add missing `main` in package.json (open-telemetry#577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants