-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web-example): Added a README for the existing example #562
Conversation
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 90.22% 90.11% -0.11%
==========================================
Files 151 149 -2
Lines 7478 7345 -133
Branches 663 658 -5
==========================================
- Hits 6747 6619 -128
+ Misses 731 726 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @nstawski
Left a few minor suggestions but overall it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM 👍
Co-Authored-By: Daniel Dyla <[email protected]>
I will merge the PR, only build failure(docs) is due to david-dm down and unrelated to PR change. |
@nstawski grats on your first merged PR. welcome to the party |
…metry#562) Co-authored-by: Valentin Marchaud <[email protected]>
Which problem is this PR solving?
Short description of the changes