Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-example): Added a README for the existing example #562

Merged
merged 10 commits into from
Nov 21, 2019
Merged

chore(web-example): Added a README for the existing example #562

merged 10 commits into from
Nov 21, 2019

Conversation

nstawski
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Added a README file with the description on how to run the example, and a screenshot of the running page

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #562 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   90.22%   90.11%   -0.11%     
==========================================
  Files         151      149       -2     
  Lines        7478     7345     -133     
  Branches      663      658       -5     
==========================================
- Hits         6747     6619     -128     
+ Misses        731      726       -5
Impacted Files Coverage Δ
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-web/src/WebTracer.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-zipkin/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/types.ts
...ackages/opentelemetry-exporter-zipkin/src/utils.ts
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 100% <0%> (+3.7%) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 60% <0%> (+26.66%) ⬆️
... and 1 more

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @nstawski

Left a few minor suggestions but overall it looks good

examples/tracer-web/README.md Outdated Show resolved Hide resolved
examples/tracer-web/README.md Outdated Show resolved Hide resolved
examples/tracer-web/README.md Outdated Show resolved Hide resolved
examples/tracer-web/README.md Outdated Show resolved Hide resolved
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 👍

examples/tracer-web/README.md Outdated Show resolved Hide resolved
@nstawski nstawski requested a review from dyladan November 21, 2019 19:20
examples/tracer-web/README.md Outdated Show resolved Hide resolved
@nstawski nstawski requested a review from obecny November 21, 2019 19:43
@mayurkale22 mayurkale22 added the document Documentation-related label Nov 21, 2019
@mayurkale22
Copy link
Member

I will merge the PR, only build failure(docs) is due to david-dm down and unrelated to PR change.

@mayurkale22 mayurkale22 merged commit b048bb9 into open-telemetry:master Nov 21, 2019
@dyladan
Copy link
Member

dyladan commented Nov 21, 2019

@nstawski grats on your first merged PR. welcome to the party

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants