chore: upgrade to typescript-eslint v8#5478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5478 +/- ##
=======================================
Coverage 95.04% 95.04%
=======================================
Files 310 310
Lines 8008 8013 +5
Branches 1616 1620 +4
=======================================
+ Hits 7611 7616 +5
Misses 397 397
🚀 New features to boost your workflow:
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
There was a problem hiding this comment.
Hi, thanks for updating this @loganrosen 🙌
Could you please add a changelog since some of the types have changed in DiagConsoleLogger from any to unknown in @opentelemetry/api. In practice, this change should not make any difference for anyone, but I'd want to make sure it's called out in the changelog (api/CHANGELOG.md) as a feature, so that it does not get unintentionally released as a bugfix). 🙂
Other than that, this PR looks good 🙂
|
Thank you for your contribution @loganrosen! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
Which problem is this PR solving?
The repository currently depends on an old version of typescript-eslint (v5).
Short description of the changes
Upgrading to typescript-eslint v8 to pick up the latest recommended lint rules and modifying the code to be compliant with the new rules. In most cases, this required updating/adding new ignores for renamed/new rules. In other cases, non-breaking changes were made to the code to make it compliant. I also upgraded
eslintto the last v8 version due to a new stricter peer dependency requirement.How Has This Been Tested?
npm run lintandnpm run testsucceed.