[backport/v1.x] fix(sdk-metrics): don't export from PeriodicExportingMetricReader with no metrics (#5288) #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… No Metrics (open-telemetry#5288) Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x #5340 +/- ##
=======================================
Coverage ? 94.66%
=======================================
Files ? 322
Lines ? 8060
Branches ? 1633
=======================================
Hits ? 7630
Misses ? 430
Partials ? 0
|
pichlermarc
force-pushed
the
backport/5288
branch
from
94a227f to
e81a244
Compare
pichlermarc
force-pushed
the
backport/5288
branch
from
e81a244 to
9fb8c0c
Compare
pichlermarc
added
bug
trentm
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #5288 to v1.x