-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Esbuild plugin diag channel #5334
base: main
Are you sure you want to change the base?
feat: Esbuild plugin diag channel #5334
Conversation
…ntationModuleDefinition
…rumentation in bundles
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5334 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 322 322
Lines 8132 8132
Branches 1715 1715
=======================================
Hits 7690 7690
Misses 442 442 |
NodeJS 14 support will be dropped in 2.0 of the SDKs, which will land before this is merged
); | ||
return; | ||
} | ||
const names = [message.name, message.file].filter(Boolean) as string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trentm this differed from your original implementation. Idea here is to handle instrumentations that patch just the top level module (eg fastify) and instrumentations that patch specific files (eg graphQL)
Which problem is this PR solving?
Providing a way for users to auto instrument their bundled code. Diag channels based alternative to open-telemetry/opentelemetry-js-contrib#1856.
This should supersede (and is heavily inspired by) https://github.com/open-telemetry/opentelemetry-js/pull/4818/files
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested with open-telemetry/opentelemetry-js-contrib#2640.
Steps to test
npm run compile
experimental/packages/opentelemetry-instrumentation/scripts/dev-install.sh
opentelemetry-js-contrib
run that script (eg../opentelemetry-js/experimental/packages/opentelemetry-instrumentation/scripts/dev-install.sh
)opentelemetry-js-contrib
runnpm run compile
opentelemetry-js-contrib/packages/esbuild-plugin-node/
runnpm run test
Checklist: