Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dev dependencies #516

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 10, 2019

Which problem is this PR solving?

  • @opentelemetry/core and @opentelemetry/plugin-grpc are missing the @types/semver dev dependency, which causes build failures. The issue was not caught because @types/semver is in the root package.json and only manifests if yarn install has not been run in the root of the project.

Short description of the changes

  • Add missing dependencies

@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #516 into master will increase coverage by 1.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   90.24%   92.22%   +1.98%     
==========================================
  Files         141      140       -1     
  Lines        7019     6613     -406     
  Branches      619      589      -30     
==========================================
- Hits         6334     6099     -235     
+ Misses        685      514     -171
Impacted Files Coverage Δ
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 66.66% <0%> (-8.34%) ⬇️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
... and 36 more

@mayurkale22 mayurkale22 merged commit fcb0f1a into open-telemetry:master Nov 11, 2019
@Flarna Flarna deleted the fix-dependencies branch December 13, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants