refactor(resources)!: replace ResourceAttributes with Attributes #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of github.com:david-luna/opentelemetry-js into dluna/4175-replace-attrib-interfaces-resources-package
david-luna
commented
Sep 25, 2024
| @@ -32,12 +32,12 @@ import { | |||
| Span, | |||
| SpanExporter, | |||
| } from '../../../src'; | |||
| import { context } from '@opentelemetry/api'; | |||
| import { Attributes, context } from '@opentelemetry/api'; | |||
There was a problem hiding this comment.
note for reviewer: leftover from #5009
david-luna
commented
Sep 25, 2024
| @@ -36,7 +36,8 @@ import { | |||
| } from '../../../src'; | |||
| import { TestStackContextManager } from './TestStackContextManager'; | |||
| import { TestTracingSpanExporter } from './TestTracingSpanExporter'; | |||
| import { Resource, ResourceAttributes } from '@opentelemetry/resources'; | |||
| import { Attributes } from '@opentelemetry/api'; | |||
There was a problem hiding this comment.
note for reviewer: leftover from #5009
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5016 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 310 310
Lines 8147 8147
Branches 1630 1630
=======================================
Hits 7655 7655
Misses 492 492
|
pichlermarc
approved these changes
Sep 26, 2024
david-luna
deleted the
dluna/4175-replace-attrib-interfaces-resources-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Replaces
ResourceAttributeswithAttributesRefs #4175
Short description of the changes
Replace the interfaces in sources & tests. This PR targeting
nextsince the version bump of@opentelemetry/apipackage and the changes in public types make it a breaking change.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: