-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): script to align workspace on new semconv package version #4937
Conversation
This is to be used as part of the semconv release process. Refs: open-telemetry#4904
@JamieDanielson Example running it in a checkout of #4936:
|
I believe these will go into the - "prepare_release:semconv:patch": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_patch && npm run _restore:package-json && npm run _changelog:prepare_semconv",
- "prepare_release:semconv:minor": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_minor && npm run _restore:package-json && npm run _changelog:prepare_semconv",
+ "prepare_release:semconv:patch": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_patch && lerna run align-semconv-deps && npm run _restore:package-json && npm run _changelog:prepare_semconv",
+ "prepare_release:semconv:minor": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_minor && lerna run align-semconv-deps && npm run _restore:package-json && npm run _changelog:prepare_semconv", and then every - "align-api-deps": "node ../../scripts/align-api-deps.js"
+ "align-api-deps": "node ../../scripts/align-api-deps.js",
+ "align-semconv-deps": "node ../../scripts/align-semconv-deps.js" EDIT: Re-reading this more closely, I had this wrong. Ignore the previous above comment for now 😅 |
REviewer note, the package-lock was slightly unsync'd. Here is the clean update to package-lock: diff --git a/package-lock.json b/package-lock.json
index 03d754ec0..6e75249ed 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2045,6 +2045,9 @@
"dependencies": {
"@opentelemetry/api-logs": "0.52.1",
"@opentelemetry/core": "1.25.1",
+ "@opentelemetry/exporter-logs-otlp-grpc": "0.52.1",
+ "@opentelemetry/exporter-logs-otlp-http": "0.52.1",
+ "@opentelemetry/exporter-logs-otlp-proto": "0.52.1",
"@opentelemetry/exporter-trace-otlp-grpc": "0.52.1",
"@opentelemetry/exporter-trace-otlp-http": "0.52.1",
"@opentelemetry/exporter-trace-otlp-proto": "0.52.1",
@@ -36903,6 +36906,9 @@
"@opentelemetry/context-async-hooks": "1.25.1",
"@opentelemetry/core": "1.25.1",
"@opentelemetry/exporter-jaeger": "1.25.1",
+ "@opentelemetry/exporter-logs-otlp-grpc": "0.52.1",
+ "@opentelemetry/exporter-logs-otlp-http": "0.52.1",
+ "@opentelemetry/exporter-logs-otlp-proto": "0.52.1",
"@opentelemetry/exporter-trace-otlp-grpc": "0.52.1",
"@opentelemetry/exporter-trace-otlp-http": "0.52.1",
"@opentelemetry/exporter-trace-otlp-proto": "0.52.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This is to be used as part of the semconv release process.
Refs: #4904