-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(semconv): Separate SemConv releases to allow different versioning #4904
Merged
JamieDanielson
merged 36 commits into
open-telemetry:main
from
JamieDanielson:jamie.separate-semconv-release-publishing
Aug 20, 2024
Merged
Changes from 4 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
75e644b
add new workspace for semconv
JamieDanielson 800b0cf
add separate changelog for semconv
JamieDanielson a878d34
update release scripts and workflow to separate semconv
JamieDanielson 29fdc70
update contributing guides to clarify semconv is separate
JamieDanielson df28867
add dummy entry to release-notes script for new pkg
JamieDanielson 86ceb9b
add missing parenthesis to lerna command
JamieDanielson ed3233d
fix workspace to include packages subdirectory
JamieDanielson 1d7a1bd
ensure only semconv package in release step
JamieDanielson 0f02e89
update release-notes script to just use new regex
JamieDanielson c80e747
driveby semi-colon addition
JamieDanielson 1f1657c
Merge remote-tracking branch 'jamie/main' into jamie.separate-semconv…
JamieDanielson 2485ee9
rename package to semantic-conventions
JamieDanielson 5e862fb
update semconv path in tsconfig files
JamieDanielson 4d0ea6b
update references to new path
JamieDanielson c089181
update path in semconv generate script
JamieDanielson 681c114
update path for new npm release scripts
JamieDanielson e1e0cf8
update package-lock file
JamieDanielson 6502711
move semconv to its own dir outside of pkgs
JamieDanielson 764430f
update npm scripts and workspace
JamieDanielson 5bd0661
update references to semconv path
JamieDanielson b3d170d
update relative paths in npm scripts
JamieDanielson f215805
semconv is no longer under packages
JamieDanielson c5566df
update comment for changelog script
JamieDanielson 7e56292
run npm i to update lock and update tsconfigs
JamieDanielson a1b4a21
semantic conventions will always be separate
JamieDanielson 513be69
missed a straggler
JamieDanielson 353db76
Update doc/contributing/releasing.md
JamieDanielson 3478623
remove_experimental isnt needed
JamieDanielson 62e1d9f
prepare_all should never include semconv
JamieDanielson 8c0d0c8
re-order for clarity
JamieDanielson 20b62ef
fix release script to work on macos and alpine
JamieDanielson 7ea9782
fix verify release to work on macOS
JamieDanielson 694cca0
update verbiage and call out SO answer
JamieDanielson 4348587
Merge branch 'main' into jamie.separate-semconv-release-publishing
JamieDanielson 8998d60
replace [[:digit:]] with [0-9]
JamieDanielson 94b28c7
Merge branch 'main' into jamie.separate-semconv-release-publishing
JamieDanielson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ on: | |
options: | ||
- experimental | ||
- sdk | ||
- semconv | ||
- all | ||
|
||
jobs: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
<!-- markdownlint-disable MD004 --> | ||
# CHANGELOG | ||
|
||
All notable changes to semantic conventions package in this project will be documented in this file. | ||
|
||
## Unreleased | ||
|
||
Note: This package will now be versioned according to the version of semantic conventions being provided. | ||
|
||
### :boom: Breaking Change | ||
|
||
### :rocket: (Enhancement) | ||
|
||
* feat(semconv): update semantic conventions to 1.27 (from 1.7.0) [#4690](https://github.com/open-telemetry/opentelemetry-js/pull/4690) @dyladan | ||
* Exported names have changed to `ATTR_{name}` for attributes (e.g. `ATTR_HTTP_REQUEST_METHOD`), `{name}_VALUE_{value}` for enumeration values (e.g. `HTTP_REQUEST_METHOD_VALUE_POST`), and `METRIC_{name}` for metrics. Exported names from previous versions are deprecated. | ||
* Import `@opentelemetry/semantic-conventions` for *stable* semantic conventions. Import `@opentelemetry/semantic-conventions/incubating` for all semantic conventions, stable and unstable. | ||
|
||
### :bug: (Bug Fix) | ||
|
||
### :books: (Refine Doc) | ||
|
||
### :house: (Internal) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, both of these will also bump examples and such, so they will diverge over time from the experimental/stable versioning over time. Maybe we should also exclude them from the update. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we want to ensure absolutely nothing is included in this EXCEPT for the semantic-conventions package, right? Can you look here if this matches what you're suggesting: 1d7a1bd