Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation)!:remove unused description property from interface #4847

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix(instrumentation)!:remove unused description property from interface #4847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f1c765
fix(instrumentation):remove unused description property from instrume…
blumamir Jul 3, 2024
ce95b5b
chore: changelog
blumamir Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ All notable changes to experimental packages in this project will be documented

### :boom: Breaking Change

* fix(instrumentation)!:remove unused description property from interface [#4847](https://github.com/open-telemetry/opentelemetry-js/pull/4847) @blumamir

### :rocket: (Enhancement)

### :bug: (Bug Fix)
Expand Down
7 changes: 0 additions & 7 deletions experimental/packages/opentelemetry-instrumentation/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ export interface Instrumentation<
/** Instrumentation Version */
instrumentationVersion: string;

/**
* Instrumentation Description - please describe all useful information
* as Instrumentation might patch different version of different modules,
* or support different browsers etc.
*/
instrumentationDescription?: string;

/** Method to disable the instrumentation */
disable(): void;

Expand Down