-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(examples/opentelemetry-web): use new exported string constants for semconv #4764
refactor(examples/opentelemetry-web): use new exported string constants for semconv #4764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4764 +/- ##
==========================================
- Coverage 91.04% 90.86% -0.18%
==========================================
Files 89 91 +2
Lines 1954 1960 +6
Branches 416 417 +1
==========================================
+ Hits 1779 1781 +2
- Misses 175 179 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the churn, the Changelog now has conflicts to resolve because there's been a release. The last one I looked at I was able to merge taking in both incoming and current changes, then move the changelog entry up into the Unreleased section.
Reviewing these examples I'm realizing they need some work as they don't run as specified. This change certainly doesn't make things worse, but now I'm wondering if they should be updated wholesale all at once 🤔. I'm inclined to go ahead with this change to add the service name to these examples since the work is already done (thank you for working on this!), and then separately create an issue to update this example directory. @trentm @pichlermarc curious of your thoughts here. |
no worries! |
My inclination is the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suppose this update wasn't necessary, because the preceding state wasn't using the semconv package at all. However, it is still a reasonable update.
Also fine with this 👍 |
…ts for semconv (open-telemetry#4764) * refactor(examples/opentelemetry-web): use new exported string constants for semconv * added changelog entry * deleted changelog extra line --------- Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
Updates #4567
Short description of the changes
Added usage of
@opentelemetry/semantic-conventions
and@opentelemetry/resources
to the examples inexamples/opentelemetry-web
for maintaining consistency across all examples.Type of change
How Has This Been Tested?
Checklist: