-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(examples/opentracing-shim): use new exported string constants for semconv #4761
Merged
pichlermarc
merged 3 commits into
open-telemetry:main
from
Zen-cronic:examples-opentracing-shim-semconv
Jun 5, 2024
Merged
refactor(examples/opentracing-shim): use new exported string constants for semconv #4761
pichlermarc
merged 3 commits into
open-telemetry:main
from
Zen-cronic:examples-opentracing-shim-semconv
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantic conventions package should be updated in the package.json
as well. And can you also add a changelog entry?
24 tasks
pichlermarc
approved these changes
Jun 5, 2024
pichlermarc
approved these changes
Jun 5, 2024
This was referenced Jun 27, 2024
Merged
This was referenced Jul 3, 2024
This was referenced Jul 4, 2024
This was referenced Jul 5, 2024
This was referenced Jul 17, 2024
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…s for semconv (open-telemetry#4761) * refactor(examples/opentracing-shim): use new exported string constants for semconv * updated semconv to ^1.22.0 * added changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example
opentracing-shim
packageType of change
How Has This Been Tested?
Checklist: