refactor(examples/http): use new exported string constants for semconv #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
requested changes
Jun 3, 2024
| @@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api'); | |||
| const { registerInstrumentations } = require('@opentelemetry/instrumentation'); | |||
| const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node'); | |||
| const { Resource } = require('@opentelemetry/resources'); | |||
| const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions'); | |||
| const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions'); | |||
There was a problem hiding this comment.
This is just importing it, but it's not used down below at L18
There was a problem hiding this comment.
Fixed it! Thank you.
24 tasks
pichlermarc
approved these changes
Jun 4, 2024
This was referenced Jun 27, 2024
Merged
This was referenced Jul 3, 2024
This was referenced Jul 4, 2024
This was referenced Jul 5, 2024
This was referenced Jul 17, 2024
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
open-telemetry#4750) * refactor(examples/http): use new exported string constants for semconv * added changelog entry * refactor(examples/http): actually use new exported string constants for semconv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example http package
Type of change
How Has This Been Tested?
Checklist: