Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shim-opentracing): Use tree-shakeable string constants for semconv #4746

Merged

Conversation

JohannesHuster
Copy link
Contributor

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replace deprecated imports from @opentelemetry/semantic-conventions with new (tree-shakeable) string constants for package @opentelemetry/shim-opentracing. What I did:

  • Search for “@opentelemetry/semantic-conventions” in package path.
    • Add new imports and check that new and old strings match exactly.
    • Use new imports and remove old ones.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (refactor)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
    • No new functionality
  • Documentation has been updated

@JohannesHuster JohannesHuster requested a review from a team June 1, 2024 16:11
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (ecc88a3) to head (6dad43f).
Report is 4 commits behind head on main.

Current head 6dad43f differs from pull request most recent head f002387

Please upload reports for the commit f002387 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4746      +/-   ##
==========================================
+ Coverage   91.04%   92.09%   +1.05%     
==========================================
  Files          89      150      +61     
  Lines        1954     3099    +1145     
  Branches      416      663     +247     
==========================================
+ Hits         1779     2854    +1075     
- Misses        175      245      +70     

see 62 files with indirect coverage changes

@JohannesHuster JohannesHuster force-pushed the shim-opentracing-semconv branch from f490e6d to fc832c2 Compare June 1, 2024 17:24
@pichlermarc pichlermarc added this pull request to the merge queue Jun 3, 2024
Merged via the queue into open-telemetry:main with commit 55c6c01 Jun 3, 2024
17 of 18 checks passed
@JohannesHuster JohannesHuster deleted the shim-opentracing-semconv branch June 3, 2024 17:29
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
…emconv (open-telemetry#4746)

* refactor(shim-opentracing): Use tree-shakeable string constants for semconv

* Update changelog

---------

Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants