Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base depen… #4678

Merged
merged 3 commits into from
May 6, 2024
Merged

fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base depen… #4678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d06af01
fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base depen…
AkselAllas May 3, 2024
58f7ef4
Update CHANGELOG.md
pichlermarc May 6, 2024
272392a
Merge branch 'main' into Issue-4676-add-otlp-exporter-base-to-exporte…
pichlermarc May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
* `getEnvWithoutDefaults()` would use `process.env` if it was defined when running in a browser, while `getEnv()` would always use `_globalThis`. Now both use `_globalThis` when running in a browser.
* fix(resources): prevent circular import (resource -> detector -> resource -> ...) [#4653](https://github.com/open-telemetry/opentelemetry-js/pull/4653) @pichlermarc
* fixes a circular import warning which would appear in rollup when bundling `@opentelemetry/resources`
* fix(metrics-otlp-grpc): add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc [#4678](https://github.com/open-telemetry/opentelemetry-js/pull/4678) @AkselAllas
pichlermarc marked this conversation as resolved.
Show resolved Hide resolved

### :books: (Refine Doc)

Expand Down
1 change: 1 addition & 0 deletions experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"@opentelemetry/core": "1.24.0",
"@opentelemetry/exporter-metrics-otlp-http": "0.51.0",
"@opentelemetry/otlp-grpc-exporter-base": "0.51.0",
"@opentelemetry/otlp-exporter-base": "0.51.0",
"@opentelemetry/otlp-transformer": "0.51.0",
"@opentelemetry/resources": "1.24.0",
"@opentelemetry/sdk-metrics": "1.24.0"
Expand Down
3 changes: 3 additions & 0 deletions experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
{
"path": "../opentelemetry-exporter-metrics-otlp-http"
},
{
"path": "../otlp-exporter-base"
},
{
"path": "../otlp-grpc-exporter-base"
},
Expand Down
Loading