feat(sdk-node): add serviceInstanceIdDetector to NodeSDK #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
maryliag
force-pushed
the
serviceid-detector
branch
from
b7bccf6 to
6dcde28
Compare
pichlermarc
reviewed
Apr 11, 2024
maryliag
force-pushed
the
serviceid-detector
branch
from
6dcde28 to
1991b3c
Compare
maryliag
force-pushed
the
serviceid-detector
branch
2 times, most recently
from
109f488 to
c1021db
Compare
maryliag
changed the title
maryliag
force-pushed
the
serviceid-detector
branch
from
c1021db to
914fd8c
Compare
|
Rebased branch. @pichlermarc let me know if this implementation is good, so I can add proper documentation on how to use the new detector and the |
maryliag
force-pushed
the
serviceid-detector
branch
from
95b1573 to
25fdcf8
Compare
pichlermarc
reviewed
Apr 16, 2024
maryliag
force-pushed
the
serviceid-detector
branch
2 times, most recently
from
1325021 to
6accadc
Compare
pichlermarc
approved these changes
Apr 17, 2024
Follow up from open-telemetry#4608 Adds the resource detector ServiceInstanceIDDetector on the NodeSDK constructor. It only gets added by default on any of those conditions: - the value `serviceinstance` is part of the list `OTEL_NODE_RESOURCE_DETECTORS` - `OTEL_NODE_EXPERIMENTAL_DEFAULT_SERVICE_INSTANCE_ID` is set to `true`
Signed-off-by: maryliag <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
maryliag
force-pushed
the
serviceid-detector
branch
from
6accadc to
0480298
Compare
|
nits solved! 😄 |
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…try#4626) * feat(sdk-node): add serviceInstanceIDDetector to NodeSDK Follow up from open-telemetry#4608 Adds the resource detector ServiceInstanceIDDetector on the NodeSDK constructor. It only gets added by default on any of those conditions: - the value `serviceinstance` is part of the list `OTEL_NODE_RESOURCE_DETECTORS` - `OTEL_NODE_EXPERIMENTAL_DEFAULT_SERVICE_INSTANCE_ID` is set to `true` * remove OTEL_NODE_EXPERIMENTAL_DEFAULT_SERVICE_INSTANCE_ID Signed-off-by: maryliag <[email protected]> * update readme on how to use `OTEL_NODE_RESOURCE_DETECTORS` * feedback from review * Update experimental/packages/opentelemetry-sdk-node/README.md Co-authored-by: Marc Pichler <[email protected]> * feedback from review --------- Signed-off-by: maryliag <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #4608
Adds the resource detector ServiceInstanceIDDetector on the NodeSDK constructor.
It only gets added by default if the value
serviceinstanceis part of the listOTEL_NODE_RESOURCE_DETECTORS