Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter #4605

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter #4605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b98ee65
feat(sdk-trace-base): log resoruce attributes in ConsoleSpanExporter
pichlermarc Apr 4, 2024
d796d89
fixup! feat(sdk-trace-base): log resoruce attributes in ConsoleSpanEx…
pichlermarc Apr 4, 2024
f93cfd2
Merge branch 'main' into feat/console-exporter-resource
pichlermarc Apr 4, 2024
6513763
Merge branch 'main' into feat/console-exporter-resource
pichlermarc Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/

### :rocket: (Enhancement)

feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter [#4605](https://github.com/open-telemetry/opentelemetry-js/pull/4605) @pichlermarc

### :bug: (Bug Fix)

* fix(sdk-trace-web): fix invalid timings in span events [#4486](https://github.com/open-telemetry/opentelemetry-js/pull/4486) @Abinet18
Expand Down
3 changes: 3 additions & 0 deletions packages/opentelemetry-sdk-trace-base/src/export/ConsoleSpanExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ export class ConsoleSpanExporter implements SpanExporter {
*/
private _exportInfo(span: ReadableSpan) {
return {
resource: {
attributes: span.resource.attributes,
},
traceId: span.spanContext().traceId,
parentId: span.parentSpanId,
traceState: span.spanContext().traceState?.serialize(),
Expand Down
1 change: 1 addition & 0 deletions packages/opentelemetry-sdk-trace-base/test/common/export/ConsoleSpanExporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ describe('ConsoleSpanExporter', () => {
'links',
'name',
'parentId',
'resource',
'status',
'timestamp',
'traceId',
Expand Down