-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otlp-transformer): consolidate scope/resource creation in transformer #4600
feat(otlp-transformer): consolidate scope/resource creation in transformer #4600
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
==========================================
- Coverage 92.83% 92.83% -0.01%
==========================================
Files 328 329 +1
Lines 9519 9526 +7
Branches 2050 2050
==========================================
+ Hits 8837 8843 +6
- Misses 682 683 +1
|
FYI @legendecas this is the stale #4429 with the changes I suggested to make the workflows pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with droppedAttributesCount
since it exists in the proto. However, as the key attributes
is optional, I think droppedAttributesCount
could be optional as well.
@legendecas, ah sorry I took me a while to understand what you meant on the original PR. 😅 As it's optional in the proto, and we don't set it to anything other than 0, we might as well leave it out, you're right. I pushed a commit to change this (56cf720). This way we also don't need to adapt the tests. |
…ormer (open-telemetry#4600) * [chore] consolidate scope/resource creation in transformer Signed-off-by: Bogdan Drutu <[email protected]> * fixup! [chore] consolidate scope/resource creation in transformer * fixup! [chore] consolidate scope/resource creation in transformer * chore: add changelog entry * fixup! [chore] consolidate scope/resource creation in transformer --------- Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Bogdan Drutu <[email protected]>
Which problem is this PR solving?
Resources and scopes creation are currently duplicated across all signals even though they're the same. This PR pulls them out into shared functions for all signals.
Replaces #4429