-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jaeger-remote-sampler): Implement jaeger remote sampler #4589
feat(jaeger-remote-sampler): Implement jaeger remote sampler #4589
Conversation
…legalimpurity/opentelemetry-js into feature/implement_jaeger_remote_sampler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
+ Coverage 90.77% 92.86% +2.08%
==========================================
Files 90 331 +241
Lines 1930 9571 +7641
Branches 417 2054 +1637
==========================================
+ Hits 1752 8888 +7136
- Misses 178 683 +505
|
…ger_remote_sampler
done. |
|
||
2. **Probabilistic Sampling**: If the remote configuration specifies `StrategyType.PROBABILISTIC`, it creates a `TraceIdRatioBasedSampler`. This samples a percentage of traces based on the trace ID. | ||
|
||
3. **Default Sampling**: If none of the above apply, it falls back to the initial sampler provided in the constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like lint is failing as it's missing the links used in the header. This is the footer we usually use that should fix it:
3. **Default Sampling**: If none of the above apply, it falls back to the initial sampler provided in the constructor. | |
3. **Default Sampling**: If none of the above apply, it falls back to the initial sampler provided in the constructor. | |
## Useful links | |
- For more information on OpenTelemetry, visit: <https://opentelemetry.io/> | |
- For more about OpenTelemetry JavaScript: <https://github.com/open-telemetry/opentelemetry-js> | |
- For help or feedback on this project, join us in [GitHub Discussions][discussions-url] | |
## License | |
Apache 2.0 - See [LICENSE][license-url] for more information. | |
[discussions-url]: https://github.com/open-telemetry/opentelemetry-js/discussions | |
[license-url]: https://github.com/open-telemetry/opentelemetry-js/blob/main/LICENSE | |
[license-image]: https://img.shields.io/badge/license-Apache_2.0-green.svg?style=flat | |
[npm-url]: https://www.npmjs.com/package/@opentelemetry/sampler-jaeger-remote | |
[npm-img]: https://badge.fury.io/js/%40opentelemetry%2Fsampler-jaeger-remote.svg | |
…lemetry#4589) Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Trent Mick <[email protected]>
Which problem is this PR solving?
This is an implementation of JaegerRemoteSampler. This follows the specification mentioned here.
Fixes #4534
Short description of the changes
Add a new samper implementation in experimental packages.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Have added full coverage for entire code.
Checklist: