-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-metrics): added synchronous gauge to SDK #4565
feat(sdk-metrics): added synchronous gauge to SDK #4565
Conversation
FYI @pichlermarc |
@pichlermarc given the SDK depends on the API, is the order wrong here? It seems we should update the API first. |
@clintonb ah, this is the counter-intuitive situation I mentioned over at #4565. 🙂 Since The workaround is to copy the Gauge type from the API package to the We're currently discussing ways to improve this situation with SDK 2.0 (many edge cases, difficult topic), but in the meantime this is the way forward to add the feature. 🙂 |
6131e5e
to
95f7f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, then I think this should be good to merge. 🙂
Thanks for working on this @clintonb 🚀
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4565 +/- ##
==========================================
- Coverage 92.90% 91.33% -1.57%
==========================================
Files 326 254 -72
Lines 9454 7112 -2342
Branches 2024 1614 -410
==========================================
- Hits 8783 6496 -2287
+ Misses 671 616 -55
|
1bbd61a
to
96aefb2
Compare
@pichlermarc I've rebased on main, added the Please take another look, and thanks for shepherding this! |
96aefb2
to
1dbecf2
Compare
@pichlermarc this circular dependency continues to hamper my development. The sdk-metrics tests depend on api, so I cannot increase test coverage to meet the threshold for merging. |
See #4528 for complete test coverage. |
I see. I'll merge this without the needed coverage and then we follow up on it in the next PR. 👍 |
bbff221
to
512a359
Compare
@pichlermarc rebased both branches/PRs. Ready for tests and merging. |
* feat(instrumentation): added synchronous gauge to SDK * fixup! feat(instrumentation): added synchronous gauge to SDK * fixup! feat(instrumentation): added synchronous gauge to SDK * fixup! feat(instrumentation): added synchronous gauge to SDK * fixup! feat(instrumentation): added synchronous gauge to SDK * fixup! feat(instrumentation): added synchronous gauge to SDK
Which problem is this PR solving?
Split from #4528, relates to #4296
Short description of the changes
Added SDK for synchronous gauge.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: